Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension point to specify Node.js installation location #434

Closed
sosahvictor opened this issue Jul 26, 2016 · 10 comments
Closed

Extension point to specify Node.js installation location #434

sosahvictor opened this issue Jul 26, 2016 · 10 comments

Comments

@sosahvictor
Copy link
Contributor

I've noticed that Tern.java has this extension point[1] to specify a current node.js install location so that is taken automatically when Tern preferences are initialized. However, looking at the code that reads that extension[2] I can tell that it only looks for a directory under the plugin declaring the extension point, i.e. is relative to the plugin, or else it looks for a ZIP archive in the bundle.

In my scenario, I already have a node.js installed in a different location that I know in advance.

My question, is there a way to add node.js locations in Tern.java preferences either programatically or declaratively?

[1] https://github.com/angelozerr/tern.java/blob/master/eclipse/tern.eclipse.ide.server.nodejs.core/schema/nodeJSInstalls.exsd
[2] https://github.com/angelozerr/tern.java/blob/master/eclipse/tern.eclipse.ide.server.nodejs.core/src/tern/eclipse/ide/server/nodejs/internal/core/NodejsInstall.java

@angelozerr
Copy link
Owner

My question, is there a way to add node.js locations in Tern.java preferences either programatically or declaratively?

No.

The extension point could be improved to specifiy a class to return a custom file node path.

@sosahvictor
Copy link
Contributor Author

No.

The extension point could be improved to specifiy a class to return a custom file node path.

Thanks for confirming Angelo. Will think about this. As we require this functionality, we'll be contributing a patch soon.

Quick question, talking about release timeline, do you plan to release something within the next two months? This can help to plan my work.

Thanks again.

@angelozerr
Copy link
Owner

Quick question, talking about release timeline, do you plan to release something within the next two months? This can help to plan my work.

To be honnest with you, I don't know when tern.java will be released. We do a release when there are interesting features. But SNAPSHOT version is available as soon as pushes are done.

@sosahvictor
Copy link
Contributor Author

Alright. That should be enough. I'll be in touch soon about this contribution.
Thank you, Angelo!

@angelozerr
Copy link
Owner

I'll be in touch soon about this contribution.

Cool:)

Thank you, Angelo!

You are welcome!

@sosahvictor
Copy link
Contributor Author

Hi @angelozerr.
I've created PR #435. I guess it's better to track it there. If you have the same feeling, please feel free to close this one

@angelozerr
Copy link
Owner

Thanks @sosahvictor!

Please read my comment https://github.com/angelozerr/tern.java/pull/435/files#r73936067

I close this issue.

@sosahvictor
Copy link
Contributor Author

oh, btw, where can I find the snapshot that has this change?

@angelozerr
Copy link
Owner

You can install SNAPSHOT version with update site https://github.com/angelozerr/tern.java/wiki/Installation-Update-Site

You work is included in this snapshot, see https://opensagres.ci.cloudbees.com/job/tern.java/

@sosahvictor
Copy link
Contributor Author

Thanks for the pointers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants