Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark occurrences is often completely wrong #422

Closed
acarstoiu opened this issue Jun 8, 2016 · 5 comments
Closed

Mark occurrences is often completely wrong #422

acarstoiu opened this issue Jun 8, 2016 · 5 comments

Comments

@acarstoiu
Copy link

It may be that it's not tern that provides this functionality, but JSDT. No surprise here, but can you intercept the triggering events and make it properly? It is the local only (file) version of #339.

Thanks.

@angelozerr
Copy link
Owner

tern.java doesn't support mark occurrences and it will not. It's the goal of JSDT. JSDT 2.0 (Eclipse Neon) which is sonn available is a lot improve.

I close this issue.

@acarstoiu
Copy link
Author

acarstoiu commented Jun 8, 2016

Well, I'm reporting this while running on Neon RC (JSDT 2.0.0).
Also, I wouldn't exclude taking care of occurrences in tern simply because this functionality is based on static code analysis, which is not at all the best ability of JSDT 👎

@angelozerr angelozerr reopened this Jun 9, 2016
@angelozerr
Copy link
Owner

@acarstoiu I have seen some bugs about mark occurrences inside JSDT bugzilla. I suggeset you that you post your bug in the JSDT bugzilla.

JSDT Editor doesn't give the capability to override mark occurences, so it's not possible to do it with tern. I have no time to support that, but any contribution are welcome.

@acarstoiu
Copy link
Author

If marking occurences is not override-able, then I guess the guys developing JSDT have reserved this issue for themselves. If only they used a proper parser...

@angelozerr
Copy link
Owner

JSDT 2.0.0 uses Esprima parser, but there is discussion to use Google closure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants