Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list_moly_fovs needs to ensure encoding method is 'utf-8' #232

Closed
alex-l-kong opened this issue Aug 31, 2022 · 2 comments · Fixed by #243
Closed

list_moly_fovs needs to ensure encoding method is 'utf-8' #232

alex-l-kong opened this issue Aug 31, 2022 · 2 comments · Fixed by #243
Assignees
Labels
enhancement New feature or request

Comments

@alex-l-kong
Copy link
Contributor

Describe the bug

When the Moly points are being checked, they're being opened without a specified encoding method. This can cause encoding errors.

Expected behavior

The JSON should be loaded in correctly.

Explicitly pass an encoding argument like read_json_file.

@alex-l-kong alex-l-kong added the bug Something isn't working label Aug 31, 2022
@camisowers camisowers self-assigned this Sep 2, 2022
@camisowers
Copy link
Contributor

Screen Shot 2022-09-05 at 1 01 25 PM

@camisowers
Copy link
Contributor

camisowers commented Sep 6, 2022

In this instance the json files were damaged/encoded differently on the user's local computer. I ran the same json files on my computer and the user ran them on their own MIBI computer and extraction worked fine.

I think it's still a good idea to open each json file with a utf-8 encoding using the read_json_file regardless.

@camisowers camisowers added enhancement New feature or request and removed bug Something isn't working labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants