From aed2e02105ef21cef625b367b67accbfd2cdf259 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Tue, 26 Aug 2014 11:17:33 +1000 Subject: [PATCH] fs-proc-task_mmuc-simplify-the-vma_stop-logic-checkpatch-fixes WARNING: Missing a blank line after declarations #50: FILE: fs/proc/task_mmu.c:135: + struct mm_struct *mm = priv->mm; + release_task_mempolicy(priv); ERROR: spaces required around that '?' (ctx:VxW) #86: FILE: fs/proc/task_mmu.c:220: + next = (vma != tail_vma)? tail_vma: NULL; ^ ERROR: spaces required around that ':' (ctx:VxW) #86: FILE: fs/proc/task_mmu.c:220: + next = (vma != tail_vma)? tail_vma: NULL; ^ total: 2 errors, 1 warnings, 65 lines checked ./patches/fs-proc-task_mmuc-simplify-the-vma_stop-logic.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Oleg Nesterov Signed-off-by: Andrew Morton --- fs/proc/task_mmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 909330b25bbd23..ba9c1392bcb815 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -132,6 +132,7 @@ static void release_task_mempolicy(struct proc_maps_private *priv) static void vma_stop(struct proc_maps_private *priv) { struct mm_struct *mm = priv->mm; + release_task_mempolicy(priv); up_read(&mm->mmap_sem); mmput(mm); @@ -217,7 +218,7 @@ static void *m_next(struct seq_file *m, void *v, loff_t *pos) if (vma && (vma != tail_vma) && vma->vm_next) return vma->vm_next; - next = (vma != tail_vma)? tail_vma: NULL; + next = (vma != tail_vma) ? tail_vma : NULL; if (!next) vma_stop(priv); return next;