This repository has been archived by the owner on Jun 10, 2019. It is now read-only.
NVMe support for ec2 provider #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: andsens#452 Adds support for building on EC2 hosts that have NVMe EBS devices. Introduces the DescribeInstances permission requirement for the calling role. Changes the device naming logic on the host during build time. - The new target volume will be mounted with the highest available DeviceName in the BlockDeviceMapping object, taking care to avoid assignments that also are allocated at launch to ephemeral devices (C5d, I3, F1, and M5d currently). - The system device name will be identifed by the difference between the existing block devices prior to and after the AttachVolume call has finished. This does not address the race condition identified in andsens#459.
|
Wow. Nice job on these PRs, they look really good. I have reviewed and merged the easiest one. I hope I can find the time this week to review this one and #485. |
auvipy
suggested changes
Jun 7, 2019
|
Hey John, thank you for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #452
Adds support for building on EC2 hosts that have NVMe EBS devices.
Introduces the DescribeInstances permission requirement for the calling
role.
Changes the device naming logic on the host during build time.
DeviceName in the BlockDeviceMapping object, taking care to avoid
assignments that also are allocated at launch to ephemeral devices
(C5d, I3, F1, and M5d currently).
existing block devices prior to and after the AttachVolume call has
finished. This does not address the race condition identified in EC2 EBS race condition when parallelizing jobs #459.