Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Building Docker images with a description fails #373

Open
KellerFuchs opened this issue Apr 17, 2017 · 3 comments
Open

Building Docker images with a description fails #373

KellerFuchs opened this issue Apr 17, 2017 · 3 comments

Comments

@KellerFuchs
Copy link
Contributor

The task tasks.image.CreateImage fails when providers.label.description is set, seemingly due to improper quoting in the docker invocation.
See build log

@KellerFuchs
Copy link
Contributor Author

KellerFuchs commented Apr 17, 2017

Amusingly, the last commit there was mine (eca54d6), to fix an issue with the exact same thing.
I guess there was a breaking change in the Docker CLI?

@andsens
Copy link
Owner

andsens commented Apr 23, 2017

Ah yes, I remember this, there was quite a bit of hassle with those labels.
This:

'LABEL description='"'"'Hashbang shell server, based on Debian jessie'"'"''

looks really bad. What was the value in your manifest?
I agree with the sentiment of using a standard escaping function, just be aware of the comment I added in the old escaping function.

Are you up for fixing this?

@KellerFuchs
Copy link
Contributor Author

The manifest had this:

description: "Hashbang shell server, based on Debian {system.release}"

We are in the process of moving this particular build away from bootstrap-vz, since we aren't really taking advantage of it there, but I have other manifests that exhibit the same issue so I could prepare a patch for those.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants