From 77c7c189a6b60444fd3d41acedf6f0fe7efab7f8 Mon Sep 17 00:00:00 2001 From: Alex Kinney Date: Tue, 13 Jun 2023 13:30:48 -0400 Subject: [PATCH 1/2] Fixed typo when determining 'rotationDegrees' projectionPosePitch => projectionPoseRoll --- .../androidx/media3/extractor/mkv/MatroskaExtractor.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java b/libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java index ed466f81474..9d2c4e6ce8b 100644 --- a/libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java +++ b/libraries/extractor/src/main/java/androidx/media3/extractor/mkv/MatroskaExtractor.java @@ -2293,12 +2293,12 @@ public void initializeOutput(ExtractorOutput output, int trackId) throws ParserE // The range of projectionPoseRoll is [-180, 180]. if (Float.compare(projectionPoseRoll, 0f) == 0) { rotationDegrees = 0; - } else if (Float.compare(projectionPosePitch, 90f) == 0) { + } else if (Float.compare(projectionPoseRoll, 90f) == 0) { rotationDegrees = 90; - } else if (Float.compare(projectionPosePitch, -180f) == 0 - || Float.compare(projectionPosePitch, 180f) == 0) { + } else if (Float.compare(projectionPoseRoll, -180f) == 0 + || Float.compare(projectionPoseRoll, 180f) == 0) { rotationDegrees = 180; - } else if (Float.compare(projectionPosePitch, -90f) == 0) { + } else if (Float.compare(projectionPoseRoll, -90f) == 0) { rotationDegrees = 270; } } From d4034bb9b96547184227df228952b14d586e0784 Mon Sep 17 00:00:00 2001 From: Rohit Singh Date: Tue, 20 Jun 2023 18:50:14 +0100 Subject: [PATCH 2/2] Add release notes entry for the fix --- RELEASENOTES.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RELEASENOTES.md b/RELEASENOTES.md index d558de8583e..3842ea514a8 100644 --- a/RELEASENOTES.md +++ b/RELEASENOTES.md @@ -34,6 +34,9 @@ * Parse EXIF rotation data for image inputs. * Track Selection: * Extractors: + * Fix typo when determining `rotationDegrees`. Changed + `projectionPosePitch` to `projectionPoseRoll` + ([#461](https://github.com/androidx/media/pull/461)). * Audio: * Audio Offload: * Add `AudioSink.getFormatOffloadSupport(Format)` that retrieves level of