From a2a13d37684af419966f1863a34b0cebf5ce6af7 Mon Sep 17 00:00:00 2001 From: omustardoG Date: Mon, 6 Jan 2025 12:24:10 -0800 Subject: [PATCH 1/2] Reword a precondition message. In "never be called after" the "be" is extraneous and should definitely be removed. I modified the entire phrase to what I think is more readable. --- .../androidx/test/core/app/InstrumentationActivityInvoker.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/java/androidx/test/core/app/InstrumentationActivityInvoker.java b/core/java/androidx/test/core/app/InstrumentationActivityInvoker.java index 6ea23654e..dbaa81c6c 100644 --- a/core/java/androidx/test/core/app/InstrumentationActivityInvoker.java +++ b/core/java/androidx/test/core/app/InstrumentationActivityInvoker.java @@ -289,7 +289,7 @@ public ActivityResult getActivityResult() { } checkNotNull( activityResult, - "onActivityResult never be called after %d milliseconds", + "onActivityResult was not called within %d milliseconds", ActivityLifecycleTimeout.getMillis()); return activityResult; } From e8cbbaee0042cf796e4e9e5bef5097fd9991beed Mon Sep 17 00:00:00 2001 From: omustardoG Date: Tue, 7 Jan 2025 11:55:46 -0800 Subject: [PATCH 2/2] Update CHANGELOG.md --- core/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md index 8fc9c5710..6f3f1d98b 100644 --- a/core/CHANGELOG.md +++ b/core/CHANGELOG.md @@ -7,7 +7,7 @@ **Bug Fixes** * Fix `Rect` handling in `ViewCapture` for SDK >= 34 for non root views. * Fix bug reporting the status code when PixelCopy fails in ViewCapture.generateBitmapFromPixelCopy. - +* Improving wording of a failure message. **New Features**