-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ruby version to 3.2.2 #20
Upgrade Ruby version to 3.2.2 #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps there should be a way to specify the ruby version from the workflow file so that it can pick the version used in the project (from .ruby-version
file instead of hard-coding like this)
Good shout. In this instance, it would need to be a build argument. |
And it does not seem to have support https://github.com/orgs/community/discussions/25241 There are some workarounds for it though. |
This issue makes this Github action completely unusable now. The latest versions of StandardRB require a later Ruby version. I'm wondering if the Ruby version pinning is required. Why not always use the latest version to also be compatible with the latest versions of StandardRB? This prevents the need for build arguments. |
I wanted to try out the action today, and I ran into this issue. Now, Bundler needs at least Ruby 3.0 to install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use custom build argument as suggested here? https://github.com/orgs/community/discussions/25241#discussioncomment-3247045
That way we end up using the ruby-version of the project. Note that not everyone uses the same version of ruby.
@andrewmcodes would it be possible to merge this? |
For anyone finding this, the workaround is to use @BWherryImpero 's branch: - name: StandardRB Linter
# uses: andrewmcodes/standardrb-action@v1.0.0 # This is mainline
uses: BWherryImpero/standardrb-action@upgrade-ruby-version
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Hallelujah! It's been merged! I was gonna fork it and change the one line for the mean time. Didn't realize someone already did. Thanks, Andrew ❤️ |
@kmcphillips you should be able to use @Samuelodan no problem! Please do consider just saving on your execution time by replacing this action with the following: standardrb:
name: StandardRB
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true
- run: bundle exec standardrb --format github --parallel Which will create the annotations for you just like this action does but without the extra overhead. |
We're getting errors using this action as the installed version of Ruby is 2.6 and current versions of standard (via the Rubocop dependency) require a Ruby version of 2.7+.
This PR updates the version of Ruby to 3.2.2