Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use ISerializable instead of using a JSonConverter #1

Closed
kYann opened this issue Jul 17, 2019 · 2 comments
Closed

Why not use ISerializable instead of using a JSonConverter #1

kYann opened this issue Jul 17, 2019 · 2 comments
Assignees
@andrewlock

Comments

@kYann
Copy link

kYann commented Jul 17, 2019

Hi,

Nice project !
Why not use the ISerialiazable interface avaible since .Net Standard 2.0 to allow json conversion without the need of a reference on JSonConverter ?
https://www.newtonsoft.com/json/help/html/SerializationGuide.htm#ISerializable

Maybe it could be an option ?
@andrewlock
Copy link
Owner

Thanks!
To be honest, I rarely use ISerializable. It's just such an ugly API 😉

It could be an option, sure, but I don't have a great inclination to add it at the moment. PRs always welcome 🙂

@andrewlock
Copy link
Owner

If this is something you still want you can now do it with the work in #117 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewlock andrewlock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kYann @andrewlock