Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of duplicate file names #39

Open
andrewhickman opened this issue Apr 16, 2023 · 0 comments
Open

Handling of duplicate file names #39

andrewhickman opened this issue Apr 16, 2023 · 0 comments

Comments

@andrewhickman
Copy link
Owner

Currently if two files with the same name are added, the second one is silently ignored. This is intended to support loading the same dependency from multiple file descriptor sets (especially common ones like the google/protobuf files. However this behaviour might be confusing if the files have different content.

Additionally, its annoying to have to come up with a unique filename when adding files programatically (#30, #32). Maybe the library should allow skip the uniqueness check for such files (e.g. by setting the name field to None)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant