Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross compilation failing for aarch64 target in github actions #440

Closed
andrewdavidmackenzie opened this issue Sep 13, 2024 · 6 comments · Fixed by #448
Closed

cross compilation failing for aarch64 target in github actions #440

andrewdavidmackenzie opened this issue Sep 13, 2024 · 6 comments · Fixed by #448
Assignees
Milestone

Comments

@andrewdavidmackenzie
Copy link
Owner

e.g. https://github.com/andrewdavidmackenzie/pigg/actions/runs/10850493649

I might disable cross build, so CI is green, until we can fix this...

@andrewdavidmackenzie
Copy link
Owner Author

To work on this issue, uncomment the "cross" job in build_and_test.yml and then when working that change can be merged, so that CI should be passing before and after the change.

@sundaram123krishnan
Copy link
Collaborator

sundaram123krishnan commented Sep 14, 2024

For now we can test on armv7 architecture, will open a separate PR for fixing cross compilation for aarch64 target @andrewdavidmackenzie

@sundaram123krishnan sundaram123krishnan changed the title cross build failing in GH Actions cross compilation failing for aarch64 target in github actions Sep 14, 2024
@sundaram123krishnan
Copy link
Collaborator

We can refer to this issue rust-lang/rust#73493.
They had also faced a similar problem.
Maybe, we need to pass link_arg ?
@andrewdavidmackenzie

@sundaram123krishnan
Copy link
Collaborator

I can also find a discussion related to it in rust-skia.
rust-skia/rust-skia#959

@andrewdavidmackenzie
Copy link
Owner Author

Need to understand what is different in local vs. GH Actions...

@andrewdavidmackenzie
Copy link
Owner Author

Maybe we should try in local with intrument coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants