-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #120
Merged
Merged
V2 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- relocate to src/ - update template - simplify default styles - use :active pseudo selector - use default focus behaviour - ignore click jump thumb clicks
- npm run check - npm run lint
- fix disabled getter return value - element should not be focusable when disabled - ignore _startHandler when disabled - remove unnecessary [disabled] pointer-events property
- introduce track-fill - introduce runnable-track - fix aria-valuenow update on value change - fix: reflectValue Ensure we use the custom element to measure fullSize. Otherwise target might be data-track-fill etc which would cause false value computation.
- interactive playground for styling
- inherit `border-radius` from root element (easier to overwrite) - `--track-fill-clamp` (keep things dry with `--value-percentage` fallback)
Make it easier to overwrite the default styles.
Ensure the event.target is self (range-slider) and not the thumb or any thumb children etc. This avoids incorrect percent calculations when passing the event.offsetX/Y from a wrong target and not self. So far only seen on iOS devices on the initial touch move. Might be a `pointer-events: none` issue on iOS.
Generates a changelog based on commits since the last semver tag instead generating all previous changelogs and overwrite them. https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-changelog-cli
- Content updates - Introduce dynamic syntax highlighting for the CSS playground using the latest syntax-highlight-element v1.0.0-rc.3 - Readme: add badges
- feature detect CSS.highlights to prevent undefined syntaxHighlightElement.update function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (additional context)
Bug fixes
Features:
Breaking Changes:
:active
pseudo selectorOther: