Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support custom protocols for styles #333

Merged
merged 13 commits into from
Apr 7, 2021

Conversation

jaysonsantos
Copy link
Contributor

@jaysonsantos jaysonsantos commented Mar 28, 2021

Proposed changes

When it is done, this should allow URLs like github://, gh://, and others.

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's new API, functionality, etc.:
    • On README.md
    • On docs/*.rst files

@jaysonsantos jaysonsantos marked this pull request as draft March 28, 2021 20:40
@jaysonsantos jaysonsantos changed the title wip feat: Support custom protocols for styles Mar 28, 2021
@jaysonsantos jaysonsantos force-pushed the support-protocols branch 10 times, most recently from 06802da to 94590ed Compare March 29, 2021 20:18
@andreoliwa andreoliwa self-requested a review March 29, 2021 20:22
@jaysonsantos jaysonsantos force-pushed the support-protocols branch 2 times, most recently from d7c0016 to 6935859 Compare March 29, 2021 21:18
@andreoliwa andreoliwa removed their request for review March 30, 2021 08:54
@jaysonsantos jaysonsantos marked this pull request as ready for review March 30, 2021 12:06
@coveralls
Copy link

coveralls commented Mar 30, 2021

Pull Request Test Coverage Report for Build 724437948

  • 362 of 375 (96.53%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.04%) to 95.988%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nitpick/style/fetchers.py 106 108 98.15%
src/nitpick/style/core.py 165 176 93.75%
Totals Coverage Status
Change from base Build 724267616: 1.04%
Covered Lines: 1789
Relevant Lines: 1838

💛 - Coveralls

@jaysonsantos jaysonsantos mentioned this pull request Mar 31, 2021
10 tasks
Copy link
Owner

@andreoliwa andreoliwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for these changes. 🥇
The StyleFetcher looks real good!

tests/test_style.py Outdated Show resolved Hide resolved
tests/test_style.py Outdated Show resolved Hide resolved
@andreoliwa andreoliwa enabled auto-merge (squash) April 7, 2021 01:23
@andreoliwa andreoliwa merged commit 9baef63 into andreoliwa:develop Apr 7, 2021
github-actions bot pushed a commit that referenced this pull request Jul 20, 2021
# [0.27.0](v0.26.0...v0.27.0) (2021-07-20)

### Bug Fixes

* **cli:** print "no violations" message ([2fedd0a](2fedd0a))
* **cli:** replace the "run" command by "fix" and "check" ([#359](#359)) ([34d2499](34d2499))
* don't fail when there is no config/root file ([#350](#350)) ([cca099a](cca099a))
* include of remote style when there is only a local style ([#349](#349)) ([032855d](032855d))
* run pre-commit hooks only on passed files ([#356](#356)) ([3db024a](3db024a))

### Features

* accept a regular GitHub URL as a style ([#361](#361)) ([8fc34cb](8fc34cb))
* enforce settings on any TOML file ([#352](#352)) ([8fd6324](8fd6324))
* fetch GitHub URLs directly ([#341](#341)) ([d3e6811](d3e6811))
* install on macOS with Homebrew ([c679adf](c679adf))
* pre-commit hook to apply changes ([#322](#322)) ([5e98e5f](5e98e5f))
* quick setup with `nitpick init` command ([#347](#347)) ([3156afe](3156afe))
* read configuration from `.nitpick.toml` or `pyproject.toml` ([#332](#332)) ([612ae41](612ae41))
* root files for other programming languages ([#321](#321)) ([09a0e83](09a0e83))
* support custom protocols for styles ([#333](#333)) ([9baef63](9baef63))
@github-actions
Copy link

🎉 This PR is included in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jul 20, 2021
@jaysonsantos jaysonsantos deleted the support-protocols branch July 27, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Feature/fix is released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants