Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply changes to pyproject.toml #260

Closed
10 tasks done
andreoliwa opened this issue Feb 6, 2021 · 1 comment · Fixed by #287
Closed
10 tasks done

Apply changes to pyproject.toml #260

andreoliwa opened this issue Feb 6, 2021 · 1 comment · Fixed by #287
Labels
enhancement New feature or request plugin-toml Plugin for TOML files released Feature/fix is released
Milestone
Apply suggestions...

Comments

@andreoliwa
Copy link
Owner

andreoliwa commented Feb 6, 2021 •
edited
Loading

Problem

I want to apply changes to pyproject.toml.
This now possible after #255 (with some more internal refactorings).

Possible solution

  • nitpick run [files...]
  • Accept one or more files (pyproject.toml, .pre-commit-config.yaml, setup.cfg...)
  • The files should be configured in the style
  • Write back changes to the .toml file
  • Keep the file format when possible
  • Maybe use the tomlkit package to preserve TOML
  • Add tests to confirm that the file was really updated
  • Use https://github.com/google/diff-match-patch to apply changes automatically? Not now.
  • Echo ✅ 1 violation fixed automatically, ❌ 16 violations to change manually.
  • Test count of fixed and manual violations
@andreoliwa andreoliwa mentioned this issue Feb 6, 2021
Merged
@andreoliwa andreoliwa added the enhancement New feature or request label Feb 6, 2021
@andreoliwa andreoliwa changed the title Apply fixes on configuration files Apply suggestions to configuration files Feb 6, 2021
@andreoliwa andreoliwa changed the title Apply suggestions to configuration files Apply changes to pyproject.toml Feb 12, 2021
@andreoliwa andreoliwa added the plugin-toml Plugin for TOML files label Feb 13, 2021
@andreoliwa andreoliwa mentioned this issue Feb 18, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Feb 23, 2021
@andreoliwa andreoliwa moved this to Done in Nitpick Roadmap Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request plugin-toml Plugin for TOML files released Feature/fix is released
Projects
Nitpick Roadmap
Archived in project
Milestone
Apply suggestions to configuration files
Development

Successfully merging a pull request may close this issue.

feat: apply changes to pyproject.toml andreoliwa/nitpick
1 participant
@andreoliwa