From 0ac1737f0b8898abaa5d594ff165457065a3f77d Mon Sep 17 00:00:00 2001 From: Jeroen Weener Date: Wed, 19 Jul 2023 16:48:57 +0200 Subject: [PATCH] Remove `HttpAuthRequest.onCancel` --- .../lib/src/android_webview_controller.dart | 1 - .../lib/src/types/http_auth_request.dart | 4 ---- .../lib/src/webkit_webview_controller.dart | 1 - 3 files changed, 6 deletions(-) diff --git a/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart b/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart index 64170da28b91..80c32c8025c8 100644 --- a/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart +++ b/packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart @@ -1022,7 +1022,6 @@ class AndroidNavigationDelegate extends PlatformNavigationDelegate { callback( HttpAuthRequest( onProceed: httpAuthHandler.proceed, - onCancel: httpAuthHandler.cancel, host: host, realm: realm, ), diff --git a/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart b/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart index c8707dcbd1a7..30756ecab934 100644 --- a/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart +++ b/packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/http_auth_request.dart @@ -7,7 +7,6 @@ class HttpAuthRequest { /// Creates a [HttpAuthRequest]. const HttpAuthRequest({ required this.onProceed, - required this.onCancel, required this.host, required this.realm, }); @@ -15,9 +14,6 @@ class HttpAuthRequest { /// The callback to authenticate. final void Function(String username, String password) onProceed; - /// The callback to cancel authentication. - final void Function() onCancel; - /// The host requiring authentication. final String host; diff --git a/packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart b/packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart index 803ad2ebd9bb..c6e3f317e89c 100644 --- a/packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart +++ b/packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart @@ -842,7 +842,6 @@ class WebKitNavigationDelegate extends PlatformNavigationDelegate { ), ); }, - onCancel: () {}, host: host, realm: realm, ),