Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support partial TCRdist calculation with incomplete information #36

Open
andim opened this issue Mar 19, 2024 · 2 comments
Open

Support partial TCRdist calculation with incomplete information #36

andim opened this issue Mar 19, 2024 · 2 comments
Assignees
@yutanagano
Labels
enhancement New feature or request

Comments

@andim
Copy link
Owner

andim commented Mar 19, 2024

Currently the TCRdist calculation on e.g. CDR3A will fail when no TRAV gene is in the dataframe. It would be preferable if each function worked with only its required input.
@yutanagano
Copy link
Collaborator

Good point- do you know if raw tcrdist3 allows you to compute distances just for CDR3s? I remember thinking that it is possible to get CDR3-only distances but the code wants you to still have a v_gene column specified...

@andim
Copy link
Owner Author

andim commented Mar 28, 2024

Yes, it is possible using internal functions. Take a look in the find_neighbors_tcrdist function in nn.py for an example

@yutanagano yutanagano self-assigned this Mar 29, 2024
@yutanagano yutanagano added the enhancement New feature or request label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yutanagano yutanagano

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andim @yutanagano