SYFT_CONFIG environment variable not supported

[AidanDelaney]

What happened:

Running SYFT_CONFIG=foo syft package does not pick up the application config from file foo.

What you expected to happen:

Running syft -c bar packages results in the expected error unable to load config: unable to read application config="bar".

I would expect the same error when the config flag is set using an environment variable SYFT_CONFIG.

Steps to reproduce the issue:

1. Run SYFT_CONFIG=foo syft packages

Notice that the error rror during command execution: an image/directory argument is required is produced. It should fail when the application configuration file is not found.

Anything else we need to know?:

The value of configPath is passed to Application.LoadAllValues. The decision on the value of top-level happens before we load values. The values of root options should come from a viper lookup, rather than from a pflag binding.

This is related to #1143, but is a smaller scoped issue.

Environment:

• Output of syft version: latest git
• OS (e.g: cat /etc/os-release or similar): macos & linux

[kzantow]

@AidanDelaney thanks for the report -- the priority order issue. This happens to be something that we just started working on.

However, there is no option to use SYFT_CONFIG, you must specify a configuration file using the -c/--config flag.