Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in the sbom.syft.json file v0.85.0 #1935

Closed
jerry-brimacombe-talogy opened this issue Jul 13, 2023 · 3 comments
Closed

Breaking change in the sbom.syft.json file v0.85.0 #1935

jerry-brimacombe-talogy opened this issue Jul 13, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jerry-brimacombe-talogy

What happened:

Seems to be a breaking change in the sbom.syft.json file

What you expected to happen:

That the file created by syft could be used in Grype

Steps to reproduce the issue:

Install syft with
curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh | sh -s -- -b /usr/local/bin

Install grypewith
curl -sSfL https://raw.githubusercontent.com/anchore/grype/main/install.sh | sh -s -- -b /usr/local/bin

Run syft with
syft <IMAGE> -o json=/Syft/sbom.syft.json -o spdx-json=/Syft/sbom.spdx.json -o table=/Syft/table.txt

Run grype with
grype sbom:/Syft/sbom.syft.json -o table > /Grype/Grype.txt

Get error

1 error occurred:
* failed to catalog: unable to decode sbom: unable to decode syft-json: unexpected end of JSON input

Anything else we need to know?:

if I do the same with v0.84.1 is works
Did not seem to be listed in the breaking changes section.

image

Environment:

  • Output of syft version:
    v0.85.0
  • OS (e.g: cat /etc/os-release or similar):
    Ubuntu linux
@jerry-brimacombe-talogy jerry-brimacombe-talogy added the bug Something isn't working label Jul 13, 2023
@kzantow
Copy link
Contributor

kzantow commented Jul 13, 2023

Hi, @psiservices-jerrybrimacombe -- this is somewhat expected, since a compatible version of Grype has not yet been released. We'll look to get this done soon.

@jerry-brimacombe-talogy
Copy link
Author

@kzantow Thanks for the quick answer. So going forward, what would you recommend we do- pin both Grype and Syft to a version and then only update them together? rather than running the latest on both?

Should this not have been listed as a breaking change?

@kzantow
Copy link
Contributor

kzantow commented Jul 13, 2023

@psiservices-jerrybrimacombe this PR was the cause of the breaking change, it was labeled as a breaking-change: #1846 along with the item in the release notes:

Breaking Changes
Revisit the source.New* set of functions [#1866] [#1846] [wagoodman]

We're going to see how to make this type of breaking change more apparent in the readme.

In the meantime, we've released Grype v0.64.0 that should solve the problem.

As I believe this is fixed (and we've added an issue to try to keep this from happening again), I'm closing this one, but please reopen if you still have the issue with Grype v0.64!

@kzantow kzantow closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2023
@github-project-automation github-project-automation bot moved this to Done in OSS Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants