Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM improvements: scanning does not support v6 and can result in duplicate packages #1762

Closed
kzantow opened this issue Apr 26, 2023 · 0 comments · Fixed by #1778
Closed
Assignees
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@kzantow
Copy link
Contributor

kzantow commented Apr 26, 2023

What happened:
When PR #1752 was merged, I overlooked the fact that duplicate packages can get created. This should be accounted for when adding the packages from both the dependencies and packages sections.

When attempting to add a test fixture for this, I used PNPM to make a basic React project and realized that Syft doesn't support the pnpm lockfile format v6.

What you expected to happen:
Syft scans both older (v4) and newer (v6) pnpm lock files. No duplicate packages.

Steps to reproduce the issue:
Use this modified PNPM lock file (remove the .txt extension or create a new one): pnpm-lock.yaml.txt

@kzantow kzantow added bug Something isn't working good-first-issue Good for newcomers labels Apr 26, 2023
@kzantow kzantow self-assigned this May 3, 2023
@kzantow kzantow added this to OSS May 3, 2023
@kzantow kzantow moved this to In Progress in OSS May 3, 2023
@kzantow kzantow moved this from In Progress to In Review in OSS May 3, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in OSS May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant