fix: additional excessive go binary warnings #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original fix b125ea8 didn't catch all the excessive warnings, it seems like getArches can also be called on binaries that aren't neccessarily go binaries, so the messages from this should also be Trace instead of Warn. Signed-off-by: Justin Chadwell <me@jedevc.com>
kzantow
approved these changes
Jan 3, 2023
This was referenced Jan 4, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
The original fix 6560273 didn't catch all the excessive warnings, it seems like getArches can also be called on binaries that aren't neccessarily go binaries, so the messages from this should also be Trace instead of Warn. Signed-off-by: Justin Chadwell <me@jedevc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to #1424.
🐛 Fixes #1403.
The original fix b125ea8 didn't catch all the excessive warnings, it seems like getArches can also be called on binaries that aren't necessarily go binaries, so the messages from this should also be Trace instead of Warn