-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can Jsx components completion work? Is it supposed to work? #334
Comments
This should work. You can try to narrow down where things go wrong. Enable the logs and try |
Here is the relevant
Here is my jsconfig.json:
(I tried basic jsconfig with just So, if the problem is with tsserver setup, how can I fix it? |
do you get response for the completions command? If you get empty response, it's likely misconfig somewhere |
you can check the sample https://github.com/ananthakumaran/tide/blob/master/example/tsconfig.json config file which works |
Yep, here is the response:
And I can see |
This didn't work for me:
Is there any other way than to track all the files manually in jsconfig? |
ok, then it's not tsserver issue. Something going on the emacs side. Normally, company should show you the |
How can I debug this? |
@sooqua I would need a way to reproduce the issue (with my current config, I can't reproduce this issue). I can't provide instructions to debug as I am not sure where things are going wrong. I will also be quite busy for the next couple of weeks, so expect some delay in response. |
Same issue here. import React from 'react'
import {Navbar} from 'react-bootstrap'
function App() {
return (
<div>
<Na| /> << No Autocomplete
</div>
);
};
export default App tsserver logs show the request and the response is a success. |
@MeltWS could you run |
Looks like tsserver doesn't respect the |
From what understand this seems to be unavoidable? I was trying to find a way to reduce the length of entries, but couldn't, I'll have to settle for increasing the limit, not sure if this is a problem or not. After checking the logs, I noticed tides uses |
The command we are using is CompletionsRequestArgs. I think what's deprecated is probably details request (which we issue for single completion option to get even more info). As I mentioned, they seem to be ignoring the |
@ananthakumaran Thanks, just resolved my issue. Perhaps it would be worth upping the default |
@ananthakumaran I was going to open a new issue but I am getting the same thing here. I can't get auto close to work for me for whatever reason. Is there an option or something I need to enable to make this happen? |
@sethen are you talking about microsoft/TypeScript#20811? Please open a new issue if that's the case. It's not implemented yet. |
This works fine in VSCode tho? They just never implemented it in the ts server? |
I meant it's not implemented by tide. It requires some editor side integration |
I'm not sure if I'm doing something wrong, I think tsserver should support jsx completion? I'm including
company-tide
incompany-backends
but the auto-completion for custom, imported components (any known html tag actually) doesn't work.Checklist
M-x tide-restart-server
in the buffer where I had the problem.M-x tide-verify-setup
are correct.tsc
(andtslint
, if applicable) without the error or warning I'm seeing in tide.tsc
(ortslint
, if applicable) reports the error or warning I was expecting to see.typescript-mode
ortsserver
.Relevant Version Numbers
Steps to Reproduce the Bug
Expected Behavior
Actual Behavior
The text was updated successfully, but these errors were encountered: