Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): fix Angular v18/v19 support for ɵPendingTasks #1497

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Dec 13, 2024

PR Checklist

Closes #1496

What is the new behavior?

Adds support for Angular >= v19.0.4 which renamed the internal ɵPendingTasks symbol to ɵPendingTasksInternal. The content package relies on this symbol to register pending tasks during SSR to prevent serialization until the content is rendered. This keeps compatibility with projects on previous versions of Angular that use Analog.

Commmit: angular/angular@24e317c

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 25fa68a
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/675c42477d08af0008c10f97
😎 Deploy Preview https://deploy-preview-1497--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 25fa68a
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/675c42474931c3000823630f
😎 Deploy Preview https://deploy-preview-1497--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 25fa68a
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/675c4247421ea70008ce082e
😎 Deploy Preview https://deploy-preview-1497--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 25fa68a
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/675c42476336bc0008029f30
😎 Deploy Preview https://deploy-preview-1497--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 3215ab4 into beta Dec 13, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-pending-tasks branch December 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ɵPendingTasks is no longer exported by @angular/core (angular 19)
1 participant