fix(create-analog): set root property to empty on angular.json #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @alexrosepizant. The property should remain, just make it an empty string for the value |
alexrosepizant
force-pushed
the
fix-remove-useless-root-property
branch
from
e24f3aa to
8df7a16
Compare
Oh sorry... thanks for your feedback, I restored the property |
alexrosepizant
changed the title
alexrosepizant
force-pushed
the
fix-remove-useless-root-property
branch
from
8df7a16 to
945b78f
Compare
brandonroberts
approved these changes
Dec 7, 2024
|
Thanks! @allcontributors add @alexrosepizant for infra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Remove useless property on angular.json templates
Closes #1474
What is the new behavior?
Generate angular.json without root property
Does this PR introduce a breaking change?