Building issues

[ucwong]

Occurs after updating github.com/anacrolix/missinggo/v2 from v2.7.0 to v2.7.1

github.com/anacrolix/dht/v2 from v2.19.0 to v2.19.1

/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:72:3: cannot use generic type immutable.Map[K constraints.Ordered, V any] without instantiation
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:76:9: cannot use Map{…} (value of type Map) as type Mappish in return statement:
	Map does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:76:30: type interhash of interhash{} does not match immutable.Hasher[K] (cannot infer K and V)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:79:17: cannot use Map{} (value of type Map) as type Mappish in variable declaration:
	Map does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:83:9: cannot use m (variable of type Map) as type Mappish in return statement:
	Map does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:88:9: cannot use m (variable of type Map) as type Mappish in return statement:
	Map does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:107:3: cannot use generic type immutable.SortedMap[K constraints.Ordered, V any] without instantiation
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:112:9: cannot use sm (variable of type SortedMap) as type Mappish in return statement:
	SortedMap does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:117:9: cannot use sm (variable of type SortedMap) as type Mappish in return statement:
	SortedMap does not implement Mappish (missing Get method)
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:182:14: cannot use generic type immutable.List[T comparable] without instantiation
/root/go/pkg/mod/github.com/anacrolix/stm@v0.4.0/stmutil/containers.go:117:9: too many errors

[anacrolix]

@ucwong what version of Go are you using? See anacrolix/stm#5.

[ucwong]

@ucwong what version of Go are you using? See anacrolix/stm#5.

go version go1.19.2 linux/amd64

[ucwong]

It is OK when I run

go test ./... 

in stm directly

[ucwong]

Replace the type parameters in its definition with actual types may be the solution of this issue

https://github.com/anacrolix/stm/blob/4f6e80b7bb8c9a8b3036e54b6d02dcc66a690162/stmutil/containers.go#L72

[anacrolix]

Without jumping into the code and digging around, is it possible that old versions of the DHT code are pulling in versions of the STM code that don't build anymore? I don't know how far you got in the linked issue @ucwong but it all ends up at golang/go#55955.

[ucwong]

Without jumping into the code and digging around, is it possible that old versions of the DHT code are pulling in versions of the STM code that don't build anymore? I don't know how far you got in the linked issue @ucwong but it all ends up at golang/go#55955.

Just run go get -u ./... in my project and then the issue occurs when building

[ucwong]

anacrolix/stm#6

[ucwong]

anacrolix/stm#7

[anacrolix]

Let's close this in favour of anacrolix/stm#5, which is the real problem.