Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using more optimizations like LTO and PGO #5

Open
zamazan4ik opened this issue Sep 12, 2024 · 3 comments
Open

Evaluate using more optimizations like LTO and PGO #5

zamazan4ik opened this issue Sep 12, 2024 · 3 comments

Comments

@zamazan4ik
Copy link

zamazan4ik commented Sep 12, 2024

Hi!

I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance a bit (in this case, it's not critical at all but anyway).

I suggest enabling LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project since LTO consumes an additional amount of time to finish the compilation routine. If you think that a regular Release build should not be affected by such a change as well, then I suggest adding an additional release-lto profile where additionally to regular release optimizations LTO also will be added. Such a change simplifies life for maintainers and others interested in the project persons who want to build the most performant version of the application. Using ThinLTO also should help).

Additionally to LTO, I can suggest evaluating for Possum more advanced optimizations like Profile-Guided Optimization (PGO) and Post-Link Optimization (PLO). I have a lot of information (including a lot of benchmarks!) in my repository: https://github.com/zamazan4ik/awesome-pgo . However, right now LTO and PGO cannot be enabled at the same time due to a bug in Rustc: rust-lang/rust#115344 (comment) . So for now I suggest just enabling LTO and waiting for the fix in the Rustc's upstream.

Thank you.

P.S. I created the Issue since Discussions are disabled for the repository. It's not a bug report - just an improvement idea.

@zamazan4ik zamazan4ik changed the title Evaluate using optimizations like LTO and PGO Evaluate using more optimizations like LTO and PGO Sep 12, 2024
@anacrolix
Copy link
Owner

Thank you kindly! The LTO optimization would make sense, the library is used in embedded cases where it's likely that reducing its space footprint is positive. I'm not sure that in general the library is CPU sensitive, but it all helps.

@anacrolix
Copy link
Owner

I opened discussions, thanks.

@anacrolix
Copy link
Owner

I tried with

[profile.release]
lto = "fat"
opt-level = "s"

And got some milld size improvements. I didn't check any benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants