Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Add reparameterization flag to Distributions #91

Open
meissnereric opened this issue Oct 22, 2018 · 2 comments
Open

Add reparameterization flag to Distributions #91

meissnereric opened this issue Oct 22, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@meissnereric
Copy link
Contributor

This may be useful for Inference algorithms to use during automatic gradient chaining.

@meissnereric meissnereric changed the title Add reparamiterization flag to Distributions Add reparameterization flag to Distributions Oct 22, 2018
@meissnereric meissnereric added enhancement New feature or request good first issue Good for newcomers labels Oct 22, 2018
@gowtham1997
Copy link

gowtham1997 commented Oct 26, 2018

Hey,
I would love to contribute. I have read the contributions page and some examples. I am more comfortable with Tensorflow and MXnet is pretty new to me(but example codes look understandable).
@meissnereric Can you tell me the files which I should understand before starting?

@meissnereric
Copy link
Contributor Author

Hi @gowtham1997, glad to see you're interested!

The main place for this is the Distribution class.

Each Distribution subclass (e.g. Normal) will either be reparameterizable or not. This is based on the logic of how the log_pdf and draw_samples methods are implemented in that particular distribution, and affects certain functionality in how we do inference with the distribution. The Distribution class should manage that parameter, with each subclass passing in it's type to the super call when initialized.

Since this issue doesn't include expanding the inference method's logic to use that flag, you'll only need to add logic to take in the reparametrization type parameter, not actually use it anywhere. That will come later on.

Don't hesitate to ask any followup questions, happy to help explain further!

Cheers,
Eric

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants