docs: Fix build and coverage status links in README.md #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2020 00:29
Signed-off-by: Alagappan Sethuraman <alagappan.sethuraman@instacart.com>
Signed-off-by: Alagappan Sethuraman <alagappan.sethuraman@instacart.com>
feng-tao
reviewed
Aug 22, 2020
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| # Amundsen Search Service | |||
| [](https://badge.fury.io/py/amundsen-search) | |||
| [](https://travis-ci.com/lyft/amundsensearchlibrary) | |||
| [](https://codecov.io/github/lyft/amundsensearchlibrary?branch=master) | |||
| [](https://travis-ci.org/github/amundsen-io/amundsensearchlibrary) | |||
There was a problem hiding this comment.
we no longer use travis, so the badge no longer valid.
There was a problem hiding this comment.
oh interesting! what are we using now? Should I replace the url with a new one or remove it? Also, what about test coverage - that is good to keep?
There was a problem hiding this comment.
ping? Checking in on this.
There was a problem hiding this comment.
We use github action now. let's remove the badge for now. We could add it later once we figure out where to get the badge.
There was a problem hiding this comment.
Sounds good. will remove the Build status badge for now. Thanks!
Signed-off-by: Alagappan Sethuraman <alagappan.sethuraman@instacart.com>
Alagappan
changed the title
feng-tao
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alagappan Sethuraman alagappan.als@gmail.com
Summary of Changes
Fixed Build and Coverage status links in README.md file
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test