-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use query parameter for basic search [AtlasProxy] #105
feat: Use query parameter for basic search [AtlasProxy] #105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 75.86% 75.00% -0.87%
==========================================
Files 17 17
Lines 609 608 -1
Branches 75 75
==========================================
- Hits 462 456 -6
- Misses 121 127 +6
+ Partials 26 25 -1
Continue to review full report at Codecov.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@feng-tao just noticed that should've been merged |
thanks @mgorsk1 for the ping, lgtm |
7510640
to
3ae9525
Compare
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 76.01% 75.16% -0.86%
==========================================
Files 17 17
Lines 613 612 -1
Branches 76 76
==========================================
- Hits 466 460 -6
- Misses 121 127 +6
+ Partials 26 25 -1
Continue to review full report at Codecov.
|
Summary of Changes
After successful merge of https://reviews.apache.org/r/72440/ to master it's now possible to use much more flexible query parameter to conduct search. Previously we couldn't use it because sorting results only worked with entityFilters clause that used different handler, was less performant, required specific indication of fields on which searching should be done and did no full text processing (like tokenization, analyzers). Query parameter enforces full text search on all immediate attributes.
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test