fix: changed marshmallow-annotation version, temp solution #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
requested review from
bolkedebruin,
dikshathakur3119,
feng-tao,
jinhyukchang,
mgorsk1,
verdan and
a team
as code owners
feng-tao
previously approved these changes
Nov 9, 2020
feng-tao
reviewed
Nov 9, 2020
Would this be a breaking change for any service on marshmallow < 3.0? |
|
Slightly related to this, I have created RFC to introduce Python dataclasses instead of using attrs. |
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
dismissed stale reviews from feng-tao and Golodhros
via
56c59c1
dikshathakur3119
approved these changes
Nov 11, 2020
feng-tao
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Using git+https://www.github.com/hilearn/marshmallow-annotations.git@a7a2dc96932430369bdef36555082df990ed9bef#egg=marshmallow-annotations as marshmallow-annotations version while waiting for dep to be maintained and compatible with marshmallow >3.0.
CheckList
Make sure you have checked all steps below to ensure a timely review.