Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot does not disconnect from voice channel #57

Closed
DaddyRobLIVE opened this issue Jul 8, 2024 · 11 comments
Closed

Bot does not disconnect from voice channel #57

DaddyRobLIVE opened this issue Jul 8, 2024 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@DaddyRobLIVE
Copy link

Is your feature request related to a problem? Please describe.
Yes, voice chat remains open even if they are no longer in use, this causes new users not to be able to create a voice chat room for them even though there are inactive rooms.

Describe the solution you'd like
I'd like to have a bot killer timer available in the config, for example: inactivity-timer: 5m - this automatically destroys the proximity voice room if the player who started /dvc start has been offline for more than 5mins making the room available for other people's use.

Describe alternatives you've considered
I've been reloading the plugin from time to time for new rooms to be generated but the problem with this is that active voice rooms will get disconnected.

Additional context
None, thanks for your hard work!

@amsam0 amsam0 added the enhancement New feature or request label Jul 8, 2024
@amsam0
Copy link
Owner

amsam0 commented Jul 8, 2024

Do the players run /dvc stop or leave the game, or do they just leave the voice channel while still playing the game? If they are still playing ask them to run /dvc stop when they are done

@DaddyRobLIVE
Copy link
Author

Most players won't bother typing /dvc stop. They will just leave the server.

My suggestion above would be a good way since it'll be a hassle to keep opening a voice room using /dvc start if you get disconnected. But having a disconnection timer is good to give them some time to reconnect to the call.

@amsam0
Copy link
Owner

amsam0 commented Jul 8, 2024

If they leave the server the bot should stop itself. If it doesn't, that's a bug

@DaddyRobLIVE
Copy link
Author

DaddyRobLIVE commented Jul 8, 2024

Oh really? Well, that might be a bug then. I do like the feature that the bot remains so that just in case the player disconnected especially for mobile users they can just join the room and when they enter the server they're automatically connected to the voice chat. I hope you will consider this suggestion as connecting to Discord using a mobile phone and then playing on that same phone is very tedious.

@amsam0
Copy link
Owner

amsam0 commented Jul 8, 2024

So when a player using voice chat leaves the server, does the bot leave the voice channel?

@DaddyRobLIVE
Copy link
Author

So when a player using voice chat leaves the server, does the bot leave the voice channel?

The bot remains.

@amsam0
Copy link
Owner

amsam0 commented Jul 8, 2024

Are there any logs after/before the player leaves?

@DaddyRobLIVE
Copy link
Author

I will check the console for logs.

@amsam0 amsam0 changed the title Kill inactive rooms Bot does not disconnect from voice channel Jul 9, 2024
@amsam0 amsam0 added bug Something isn't working and removed enhancement New feature or request labels Jul 9, 2024
@amsam0 amsam0 closed this as completed in 6e05333 Jul 9, 2024
@amsam0
Copy link
Owner

amsam0 commented Jul 9, 2024

@amsam0
Copy link
Owner

amsam0 commented Jul 9, 2024

If the bug fix doesn't fix the issue with you, feel free to make a feature request with the information you said earlier.

@DaddyRobLIVE
Copy link
Author

Got it. I will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants