From 2054255e2be311571e74527b4a33a82053534c26 Mon Sep 17 00:00:00 2001 From: Jake Fried Date: Wed, 9 Jun 2021 11:42:07 -0400 Subject: [PATCH] typechecking: remove pride as not compatible with rest of strategy --- build-system/tasks/check-types.js | 37 ------------------------------- 1 file changed, 37 deletions(-) diff --git a/build-system/tasks/check-types.js b/build-system/tasks/check-types.js index c713255bbdf8..36a912b60f74 100644 --- a/build-system/tasks/check-types.js +++ b/build-system/tasks/check-types.js @@ -41,33 +41,6 @@ const CORE_SRCS_GLOBS = [ 'third_party/css-escape/css-escape.js', ]; -/** - * Files that pass type-checking but don't belong to a passing directory target. - * Note: This is a TEMPORARY holding point during the transition to type-safety. - * @type {!Array} - */ -const PRIDE_FILES_GLOBS = [ - ...CORE_SRCS_GLOBS, - - // Runtime - 'build/amp-loader-0.1.css.js', - 'build/ampdoc.css.js', - 'build/ampshared.css.js', - 'src/config.js', - 'src/dom.js', - 'src/format.js', - 'src/internal-version.js', - 'src/json.js', - 'src/log.js', - 'src/mode.js', - 'src/types.js', - - // Third Party - 'third_party/webcomponentsjs/ShadowCSS.js', - 'node_modules/promise-pjs/package.json', - 'node_modules/promise-pjs/promise.mjs', -]; - /** * Generates a list of source file paths for extensions to type-check * Must be run after `maybeInitializeExtensions` @@ -143,16 +116,6 @@ const TYPE_CHECK_TARGETS = { warningLevel: 'QUIET', }, - // Opposite of `shame.extern.js`. This target is a catch-all for files that - // are currently passing, but whose parent directories are not fully passing. - // Adding a file or glob here will cause CI to fail if type errors are - // introduced. It is okay to remove a file from this list only when fixing a - // bug for cherry-pick. - 'pride': { - srcGlobs: PRIDE_FILES_GLOBS, - externGlobs: ['build-system/externs/*.extern.js'], - }, - // Ensures that all files in src and extensions pass the specified set of // errors. 'low-bar': {