Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement iframe resizing for amp-ad #814

Closed
cramforce opened this issue Oct 31, 2015 · 4 comments
Closed

Implement iframe resizing for amp-ad #814

cramforce opened this issue Oct 31, 2015 · 4 comments
Assignees
@camelburrito
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code Type: Feature Request WG: monetization

Comments

@cramforce
Copy link
Member

Same behavior as amp-iframe. See #728
@cramforce cramforce mentioned this issue Oct 31, 2015
Closed
@jmadler
Copy link
Contributor

jmadler commented Nov 10, 2015

Does this cover 3p embeds as well, or will we need a separate issue to track that?

@cramforce
Copy link
Member Author

@jmadler Basically yes. For non-generic embeds there will be a small bit of code in the element implementation. Single function call should do it.

@dvoytenko dvoytenko mentioned this issue Nov 25, 2015
Merged
@cramforce
Copy link
Member Author

@dvoytenko Can you take this on or should we redistribute?

@dvoytenko
Copy link
Contributor

I'll assign to @sriramkrish85 . He just recently had to deal with it.

@dvoytenko dvoytenko assigned camelburrito and unassigned dvoytenko Jan 7, 2016
@camelburrito camelburrito added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label Jan 21, 2016
@camelburrito camelburrito mentioned this issue Jan 21, 2016
Merged
@MattChilders92 MattChilders92 mentioned this issue Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelburrito camelburrito

Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code Type: Feature Request WG: monetization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cramforce @jmadler @dvoytenko @camelburrito @rudygalfi