You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#7785 added setting hidden attribute to elements that get hidden by calling the hide action or component.collapse() but #7879 removed it because the change broke some components such as lightbox.
The reason for breakage was that some components assumed collapse() only sets display:none and had code that would only reset display to show.
We should bring back setting hidden attribute to hide action because it is semantic. Solution might be as simple as moving the logic to our toggle helper function (not the toggle action) but requires some manual testing to be sure it won't have side-effects.
The text was updated successfully, but these errors were encountered:
#7785 added setting
hidden
attribute to elements that get hidden by calling thehide
action orcomponent.collapse()
but #7879 removed it because the change broke some components such as lightbox.The reason for breakage was that some components assumed
collapse()
only setsdisplay:none
and had code that would only resetdisplay
to show.We should bring back setting
hidden
attribute tohide
action because it is semantic. Solution might be as simple as moving the logic to ourtoggle
helper function (not the toggle action) but requires some manual testing to be sure it won't have side-effects.The text was updated successfully, but these errors were encountered: