Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement shared video interface for amp-video and youtube #4113

Closed
cramforce opened this issue Jul 18, 2016 · 3 comments
Closed

Implement shared video interface for amp-video and youtube #4113

cramforce opened this issue Jul 18, 2016 · 3 comments
Assignees
@aghassemi
Labels
Type: Feature Request
Milestone
New FRs

Comments

@cramforce
Copy link
Member

Lets see how far we get with implementing #3945 against amp-video and amp-youtube as a blackbox.

This should help as a reference implementation for #3945 for other players.
@cramforce cramforce mentioned this issue Jul 18, 2016
Closed
@ericlindley-g ericlindley-g added this to the Next milestone Jul 19, 2016
@ericlindley-g
Copy link
Contributor

From #3945 it sounds like "Next" is the right milestone for this, but please feel free to correct/update

@aghassemi aghassemi mentioned this issue Jul 21, 2016
Closed
29 tasks
@aghassemi aghassemi mentioned this issue Aug 31, 2016
Merged
@adelinamart
Copy link
Contributor

Do we still need to work on this?

@aghassemi
Copy link
Contributor

nope, both amp-video and youtube support the new video interface. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghassemi aghassemi

Labels
Type: Feature Request
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
4 participants
@cramforce @aghassemi @ericlindley-g @adelinamart