Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken in Chrome 93 #35898

Closed
1 of 4 tasks
samouri opened this issue Aug 31, 2021 · 4 comments
Closed
1 of 4 tasks

Tests broken in Chrome 93 #35898

samouri opened this issue Aug 31, 2021 · 4 comments

Comments

@samouri
Copy link
Member

samouri commented Aug 31, 2021

summary
11 tests broke once our CI systems updated to Chrome 93. We should address this in two stages:

  1. Skip all of the newly failing tests to unblock new code from merging (including a CP we'd like to get through). Skip new test failures after Chrome93 release #35900
  2. Fix the broken tests and unskip them

skipped tests

  • (8) Highlight handler
  • (1) amp-pan-zoom
  • (1) 3p ampcontext.js
  • (1) iframe-transport-client
@samouri
Copy link
Member Author

samouri commented Sep 13, 2021

@dmanek: would you be interested in fixing all of the Highlight handler tests that failed as part of the Chrome 93 release? I started giving it a go in #35897, but think you may have better context.

I can take the rest

@dmanek
Copy link
Contributor

dmanek commented Sep 13, 2021

Started looking into this, but seems like you have the highlight handlers tests covered in #35897.

@dmanek
Copy link
Contributor

dmanek commented Sep 14, 2021

Highlight handler tests are fixed.

@dmanek dmanek removed their assignment Apr 21, 2022
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@samouri samouri closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants