Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Error: Cannot read property 'element' of undefined #28888

Closed
ampprojectbot opened this issue Jun 15, 2020 · 5 comments · Fixed by #28895
Closed

🚨 Error: Cannot read property 'element' of undefined #28888

ampprojectbot opened this issue Jun 15, 2020 · 5 comments · Fixed by #28895
Assignees
Labels
P0: Drop Everything Type: Error Report An error reported by AMP Error Reporting

Comments

@ampprojectbot
Copy link
Member

Details

Error report: link
First seen: Jun 15, 2020
Frequency: ~ 1,148/day

Stacktrace

Error: Cannot read property 'element' of undefined
    at parentResource (src/service/owners-impl.js:151:16)
    at elements (src/service/owners-impl.js:150:4)
    at findResourcesInElements_ (src/service/owners-impl.js:98:4)
    at scheduleUnlayout (extensions/amp-list/0.1/amp-list.js:1073:12)
    at toArray (extensions/amp-list/0.1/amp-list.js:1072:10)
    at mutator (src/service/mutator-impl.js:233:8)
    at callback (src/service/vsync-impl.js:470:16)
    at callTask_ (src/service/vsync-impl.js:426:8)

Notes

@lannka modified src/service/owners-impl.js:151-188 in #24222 (Aug 30, 2019)
@renovate-bot modified src/service/owners-impl.js:150-150 in #27350 (Mar 30, 2020)
@renovate-bot modified src/service/owners-impl.js:98-98 in #27350 (Mar 30, 2020)
@powerivq modified src/service/mutator-impl.js:231-233 in #26638 (Feb 12, 2020)
@jridgewell modified src/service/vsync-impl.js:470-471 in #20836 (Feb 14, 2019)

Seen in:

  • 06-13 Nightly (0233)

Possible assignees: @powerivq, @lannka

/cc @ampproject/release-on-duty

@ampprojectbot ampprojectbot added the Type: Error Report An error reported by AMP Error Reporting label Jun 15, 2020
@zhouyx
Copy link
Contributor

zhouyx commented Jun 15, 2020

New error. @ampproject/wg-runtime could please take a look and set priority of the issue.

@rcebulko
Copy link
Contributor

Note that this is a very high frequency for a Nightly error, given the small share of traffic it gets. If this reaches production, we'll see approx. 250k/day

@jridgewell
Copy link
Contributor

We're aware, and UI team is working on a fix. /to @krdwan

@jridgewell jridgewell assigned krdwan and unassigned jridgewell Jun 15, 2020
@estherkim
Copy link
Collaborator

Note that this is a very high frequency for a Nightly error, given the small share of traffic it gets. If this reaches production, we'll see approx. 250k/day

Luckily this shouldn't reach beta this week; the beta candidate should be 2006112352000

@krdwan
Copy link
Contributor

krdwan commented Jun 15, 2020

The fix is merged:
#28895

Thanks @jridgewell @caroqliu @zhouyx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0: Drop Everything Type: Error Report An error reported by AMP Error Reporting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants