-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator fails for mustache template variables inside template node #2670
Comments
I can reproduce. The issue is not new and is specific to the tag layout calculation which handles |
@Gregable I see. In this case, we have to skip this part of validation in template. Perhaps to reduce the negative impact, we can only skip it when width/height/layout and other related values use expressions in them. |
Agreed. |
Is there an open PR for this? |
Not yet. |
OK, moving to next milestone. Thanks for the update! |
@Gregable ping? Should we roll into next sprint or into backlog? |
This one is 'done', I'm working on releasing it to github as we 'speak'. |
This will go live to in-browser validation next week most likely. |
This is live everywhere. |
The validator as of v1457721872758 fails when including a mustache template inline, such as in an
amp-list
. For example, the following markup should be valid:The validator produces the following error:
cc @dvoytenko @Gregable
The text was updated successfully, but these errors were encountered: