Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Timer class to use a custom key type instead of number #21804

Closed
rsimha opened this issue Apr 10, 2019 · 3 comments
Closed

Refactor the Timer class to use a custom key type instead of number #21804

rsimha opened this issue Apr 10, 2019 · 3 comments

Comments

@rsimha
Copy link
Contributor

rsimha commented Apr 10, 2019

This came out of the discussion at #21618 (comment)

We currently use number as the default type in the Timer class. We should use a custom key type instead, that will make typecasts elsewhere in the code either unnecessary, or less ambiguous.

* @return {number|string}

* @param {number|string|null} timeoutId

@rsimha
Copy link
Contributor Author

rsimha commented Apr 10, 2019

/cc @jridgewell @aghassemi

@dreamofabear
Copy link

I assume this was @jridgewell's suggestion.

@stale
Copy link

stale bot commented Dec 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Dec 19, 2021
@stale stale bot closed this as completed Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants