Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator failing with new amp-user-notification specifications #1975

Closed
lordnerf opened this issue Feb 12, 2016 · 5 comments
Closed

Validator failing with new amp-user-notification specifications #1975

lordnerf opened this issue Feb 12, 2016 · 5 comments

Comments

@lordnerf
Copy link

AMP Validator (Version 1455227594932 - windows - chrome 48.0.2564.109 m) generates errors with new specifications of amp-user-notifications:

"amp-user-notification" (amp-user-notification1) should have "data-show-if-href" attribute.

@dvoytenko
Copy link
Contributor

@lordnerf It sounds like it's just the rollout/cache latency. Do you have an example page? Could you please also take a look at what your version prints in the DevTools console. There should be a line "Powered by AMP ⚡ HTML – Version: ????"

@erwinmombay Could you please confirm that #1943 is in PROD now?

@erwinmombay
Copy link
Member

@dvoytenko tested 1455227594932 on our examples and got rid of data-show-if-href and not getting validation errors. (have to clear my local storage to see the notification again)

@erwinmombay
Copy link
Member

oh no wait,#1943 is in canary but not in prod yet.

@erwinmombay
Copy link
Member

@lordnerf we'll move amp-access from canary to prod today. and those errors should go away. appreciate the report!

@rudygalfi
Copy link
Contributor

This is overdue on the Feb 19 milestone. Any update?

Optimistically closing, as per most recent comment this was just waiting on rollout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants