-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Closure Compiler to current #18748
Comments
Happy to work on this. |
We can also split it up. 😄 There's about a year of updates left. CC releases ~monthly. I'd recommend making each upgrade PR as small as possible to minimize risk. |
@choumx Was there a sweet spot you managed to identify when you initially attempted an upgrade to the latest version? |
I'd try the smallest upgrade possible first. https://github.com/google/closure-compiler/wiki/Binary-Downloads |
This issue hasn't been updated in awhile. @rsimha Do you have any updates? |
#21618 has brought us to 20190301. There are still some outstanding fixes that we are awaiting in the next release. I'll close this issue once we adopt it. |
We're currently at the latest version of closure. Closing this in favor of #22452, which tracks the effort to dynamically generate |
This is now truly done, and future updates should be automatic (modulo breaking changes). See #23759 (comment) |
One more success in the series: #24096 |
Having just gone through this, I'm happy to work with whomever wants to pick this up to share knowledge. Don't really mind doing this myself either.
@rsimha @alabiaga Any interest?
The text was updated successfully, but these errors were encountered: