Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Closure Compiler to current #18748

Closed
dreamofabear opened this issue Oct 15, 2018 · 9 comments
Closed

Upgrade Closure Compiler to current #18748

dreamofabear opened this issue Oct 15, 2018 · 9 comments

Comments

@dreamofabear
Copy link

Having just gone through this, I'm happy to work with whomever wants to pick this up to share knowledge. Don't really mind doing this myself either.

@rsimha @alabiaga Any interest?

@rsimha
Copy link
Contributor

rsimha commented Oct 15, 2018

Happy to work on this.

@dreamofabear
Copy link
Author

We can also split it up. 😄 There's about a year of updates left.

CC releases ~monthly. I'd recommend making each upgrade PR as small as possible to minimize risk.

@rsimha
Copy link
Contributor

rsimha commented Oct 15, 2018

@choumx Was there a sweet spot you managed to identify when you initially attempted an upgrade to the latest version?

@dreamofabear
Copy link
Author

I'd try the smallest upgrade possible first. https://github.com/google/closure-compiler/wiki/Binary-Downloads

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @rsimha Do you have any updates?

@rsimha
Copy link
Contributor

rsimha commented Apr 10, 2019

#21618 has brought us to 20190301. There are still some outstanding fixes that we are awaiting in the next release. I'll close this issue once we adopt it.

@rsimha
Copy link
Contributor

rsimha commented May 31, 2019

We're currently at the latest version of closure. Closing this in favor of #22452, which tracks the effort to dynamically generate runner.jar, so we can always be at the latest version.

@rsimha
Copy link
Contributor

rsimha commented Aug 10, 2019

This is now truly done, and future updates should be automatic (modulo breaking changes). See #23759 (comment)

@rsimha
Copy link
Contributor

rsimha commented Aug 22, 2019

One more success in the series: #24096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants