-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javascript source map on cdn.ampproject.org refers to "http://localhost:8000/" #1589
Comments
The question is: What would be a better value? How is it broken? |
Actually I noticed that in my local build it's fine - all the references in the map file are relative. But in the CDN version at https://cdn.ampproject.org/v0.js.map all references use |
They use different build methods. If you have the local server running it works, right? What is the failure you are seeing? |
Yes if I have the local sever running it works. I was just trying to examine the source directly from the CDN (via a BBC example page) without running the local server. Are you planning to include the map file and full source on the CDN for the final build? Otherwise it may be worth just leaving out the reference to the map file in the final version to avoid 404 errors for developers as happened when JQuery stopped including source files. But then you were probably going to do that anyway! |
Hey, The AMP community has been working nonstop to make AMP better, but somehow we've still managed to grow an enormous backlog of open issues. This has made it difficult for the community to prioritize what we should work on next. A new process is on the way and to give it a chance for success we will be closing issues that have not been updated in awhile. If this issue still requires further attention, simply reopen it. Please verify first whether the feature proposal is still relevant. We really appreciate the contribution! Thank you for bearing with us as we drag ourselves out of the issue abyss. :) |
The Javascript source map on the AMP CDN refers to
http://localhost:8000/
which breaks source view in the Chrome web inspector / developer console.It's not a big issue by any means but it would be nice it it were fixed!
The text was updated successfully, but these errors were encountered: