Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javascript source map on cdn.ampproject.org refers to "http://localhost:8000/" #1589

Closed
bquinn opened this issue Jan 26, 2016 · 5 comments
Closed
Milestone

Comments

@bquinn
Copy link

bquinn commented Jan 26, 2016

The Javascript source map on the AMP CDN refers to http://localhost:8000/ which breaks source view in the Chrome web inspector / developer console.

It's not a big issue by any means but it would be nice it it were fixed!

@cramforce
Copy link
Member

The question is: What would be a better value?

How is it broken?

@bquinn
Copy link
Author

bquinn commented Jan 28, 2016

Actually I noticed that in my local build it's fine - all the references in the map file are relative. But in the CDN version at https://cdn.ampproject.org/v0.js.map all references use http://localhost:8000/ - so I guess the issue is fixed and we just need to update the CDN!

@cramforce
Copy link
Member

They use different build methods. If you have the local server running it works, right?

What is the failure you are seeing?

@bquinn
Copy link
Author

bquinn commented Jan 28, 2016

Yes if I have the local sever running it works. I was just trying to examine the source directly from the CDN (via a BBC example page) without running the local server.

Are you planning to include the map file and full source on the CDN for the final build? Otherwise it may be worth just leaving out the reference to the map file in the final version to avoid 404 errors for developers as happened when JQuery stopped including source files.

But then you were probably going to do that anyway!

@rudygalfi rudygalfi added this to the M? milestone Feb 4, 2016
@adelinamart
Copy link
Contributor

Hey,

The AMP community has been working nonstop to make AMP better, but somehow we've still managed to grow an enormous backlog of open issues. This has made it difficult for the community to prioritize what we should work on next.

A new process is on the way and to give it a chance for success we will be closing issues that have not been updated in awhile.

If this issue still requires further attention, simply reopen it. Please verify first whether the feature proposal is still relevant.

We really appreciate the contribution! Thank you for bearing with us as we drag ourselves out of the issue abyss. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants