Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't see empty ads being collapsed #1412

Closed
jasti opened this issue Jan 13, 2016 · 4 comments
Closed

Don't see empty ads being collapsed #1412

jasti opened this issue Jan 13, 2016 · 4 comments

Comments

@jasti
Copy link
Contributor

jasti commented Jan 13, 2016

As per #1089 and #1265

"The amp-ad tag will be collapsed (set to display: none) if the ad sends a message that the ad slot cannot be filled and AMP determines that this operation can be performed without affecting the user's scroll position."

However,

Live page : https://dfp-amp-testing-1185.appspot.com/amp_tests/playground/dfp-iframe-collapse.html

There are two ads on the page. The first one is above the fold (the legit one that returns an ad) and the other one that is in the bottom of the page (before the last set of dummy text) that won't return an ad.

To make sure that the scroll position is not affected by the below ad, I also tried to simulate some lag by adding in some text and a dummy image.

This image highlights this as well :
https://drive.google.com/file/d/0BzVPXRfYXIOCVWtPTm1teUdBU1U/view?usp=sharing

Thoughts?

@cramforce
Copy link
Member

The feature isn't fully rolled out yet. Could you go to https://cdn.ampproject.org/experiments.html and opt into "Dev Channel" and then see whether it starts working?

@jasti
Copy link
Contributor Author

jasti commented Jan 13, 2016

Done & works great! CC @kashyapnitin

@jasti jasti closed this as completed Jan 13, 2016
@jasti
Copy link
Contributor Author

jasti commented Jan 13, 2016

Do you have a GA date for the feature?

@jasti jasti reopened this Jan 13, 2016
@cramforce
Copy link
Member

Probably tomorrow. Although the heuristic when to update is still subject to some tuning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants