diff --git a/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.html b/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.html deleted file mode 100644 index 69cfdd2bd2c8..000000000000 --- a/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.html +++ /dev/null @@ -1,41 +0,0 @@ - - - - - - - - - - - - - - - - - - diff --git a/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.out b/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.out deleted file mode 100644 index 7ef22e9a431a..000000000000 --- a/extensions/amp-social-share/0.1/test/validator-amp-social-share-pass.out +++ /dev/null @@ -1 +0,0 @@ -PASS diff --git a/extensions/amp-social-share/0.1/test/validator-amp-social-share.html b/extensions/amp-social-share/0.1/test/validator-amp-social-share.html index 52067ac7d5d0..94bcec29e5b0 100644 --- a/extensions/amp-social-share/0.1/test/validator-amp-social-share.html +++ b/extensions/amp-social-share/0.1/test/validator-amp-social-share.html @@ -25,21 +25,59 @@ + - - + + + + + - + + + + Share on Whatsapp - - + + + + Share on Whatsapp + + + + + + + + + Share on Whatsapp + + + + + Share on Whatsapp diff --git a/extensions/amp-social-share/0.1/test/validator-amp-social-share.out b/extensions/amp-social-share/0.1/test/validator-amp-social-share.out index 295aafcd16ba..8dd72b766c80 100644 --- a/extensions/amp-social-share/0.1/test/validator-amp-social-share.out +++ b/extensions/amp-social-share/0.1/test/validator-amp-social-share.out @@ -1,3 +1,3 @@ FAIL -amp-social-share/0.1/test/validator-amp-social-share.html:31:2 The specified layout 'CONTAINER' is not supported by tag 'amp-social-share'. (see https://www.ampproject.org/docs/reference/extended/amp-social-share.html) [AMP_LAYOUT_PROBLEM] -amp-social-share/0.1/test/validator-amp-social-share.html:45:7 The tag 'amp-social-share extension .js script' is missing or incorrect, but required by 'amp-social-share'. (see https://www.ampproject.org/docs/reference/extended/amp-social-share.html) [AMP_TAG_PROBLEM] +amp-social-share/0.1/test/validator-amp-social-share.html:68:2 Invalid URL protocol 'votethisup:' for attribute 'data-share-endpoint' in tag 'amp-social-share'. (see https://www.ampproject.org/docs/reference/extended/amp-social-share.html) [AMP_TAG_PROBLEM] +amp-social-share/0.1/test/validator-amp-social-share.html:76:2 Invalid URL protocol 'j a v a s c r i p t :' for attribute 'data-share-endpoint' in tag 'amp-social-share'. (see https://www.ampproject.org/docs/reference/extended/amp-social-share.html) [AMP_TAG_PROBLEM] diff --git a/extensions/amp-social-share/0.1/validator-amp-social-share.protoascii b/extensions/amp-social-share/0.1/validator-amp-social-share.protoascii index 62dcb983eafd..854a612e6c05 100644 --- a/extensions/amp-social-share/0.1/validator-amp-social-share.protoascii +++ b/extensions/amp-social-share/0.1/validator-amp-social-share.protoascii @@ -46,24 +46,6 @@ tags: { # amp-social-share } spec_url: "https://www.ampproject.org/docs/reference/extended/amp-social-share.html" } -tags: { # amp-social-share (json) - tag_name: "script" - spec_name: "amp-social-share extension .json script" - mandatory_parent: "amp-social-share" - attrs: { - name: "type" - mandatory: true - value: "application/json" - dispatch_key: true - } - cdata: { - blacklisted_cdata_regex: { - regex: "