From afa57dc9d1ba9b82e95641053f140d474d7d585a Mon Sep 17 00:00:00 2001 From: Kevin Dwan <25626770+krdwan@users.noreply.github.com> Date: Mon, 15 Jun 2020 17:13:44 -0400 Subject: [PATCH] Fix incorrect usage of scheduleUnlayout from related bug (#28895) --- extensions/amp-list/0.1/amp-list.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/extensions/amp-list/0.1/amp-list.js b/extensions/amp-list/0.1/amp-list.js index b860e4de4c2d..530844bb8ccd 100644 --- a/extensions/amp-list/0.1/amp-list.js +++ b/extensions/amp-list/0.1/amp-list.js @@ -606,13 +606,9 @@ export class AmpList extends AMP.BaseElement { 'update': false, }); } - toArray( - dev().assertElement(this.container_).children - ).forEach((child) => - this.owners_./*OK*/ scheduleUnlayout( - dev().assertElement(this.container_), - child - ) + this.owners_./*OK*/ scheduleUnlayout( + this.element, + dev().assertElement(this.container_) ); removeChildren(dev().assertElement(this.container_)); }; @@ -1069,9 +1065,7 @@ export class AmpList extends AMP.BaseElement { this.diff_(container, elements); } else { if (!opt_append) { - toArray(container.children).forEach((child) => - this.owners_./*OK*/ scheduleUnlayout(container, child) - ); + this.owners_./*OK*/ scheduleUnlayout(this.element, container); removeChildren(container); } this.addElementsToContainer_(elements, container);