Use wp_robots() instead of noindex() in WP 5.7 #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for d167936 are ready 🛎️!
|
Codecov Report
@@ Coverage Diff @@
## develop #5793 +/- ##
=============================================
- Coverage 74.23% 74.23% -0.01%
Complexity 5498 5498
=============================================
Files 201 201
Lines 16626 16628 +2
=============================================
+ Hits 12343 12344 +1
- Misses 4283 4284 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pierlon
approved these changes
Jan 21, 2021
westonruter
added a commit
that referenced
this pull request
Jan 21, 2021
…rl-customization * 'develop' of github.com:ampproject/amp-wp: Use wp_robots() instead of noindex() in WP 5.7 (#5793) Bump eslint-plugin-jsdoc from 31.0.3 to 31.0.4 Bump google/cloud-storage from 1.23.0 to 1.23.1 Bump @wordpress/block-editor from 5.2.0 to 5.2.1
westonruter
added a commit
that referenced
this pull request
Jan 21, 2021
westonruter
added a commit
that referenced
this pull request
Jan 22, 2021
…069-async-url-validation * 'develop' of github.com:ampproject/amp-wp: (41 commits) Use wp_robots() instead of noindex() in WP 5.7 (#5793) Bump eslint-plugin-jsdoc from 31.0.3 to 31.0.4 Bump google/cloud-storage from 1.23.0 to 1.23.1 Update docs Bump stable tag to 2.0.10 Add tests Restore intrinsic layout to amp-video in amp-story-page-attachment Use nonce scheme instead of auth scheme Utilize hash_equals() in unserialize_validation_error_messages() Fix jsdoc type as ReactElement Persist URL fragment through client-side mobile redirection Bump postcss from 8.2.2 to 8.2.4 Bump eslint-plugin-jsdoc from 30.7.13 to 31.0.3 Prevent infinite mobile redirect when non-AMP page served as AMP Remove the `class` attribute from `amp-fit-text` blocks to unblock block deprecation Update AMP validator spec to 8e02747, restoring intrinsic layout to amp-video Update validator spec to 1130 Update amphtml spec to 2011252111002 Bump @wordpress/compose from 3.23.0 to 3.23.1 Bump @wordpress/block-editor from 5.2.0 to 5.2.1 ...
|
QA Passed. WP 5.7-RC3With search engine visibility disabled in WordPress 5.7-RC3:
Accessing an AMP page on a site with Reader mode and the Legacy theme active, I see the expected robots meta tag and no PHP notice is emitted: <meta name="robots" content="noindex, nofollow">When search engine visibility is enabled, this is replaced with: <meta name="robots" content="max-image-preview:large">WP 5.6.2With search engine visibility disabled in WordPress 5.6.2, a Legacy AMP page shows: <meta name="robots" content="noindex,nofollow">And when search engine visibility is turned on, then no robots meta tag is added at all, as expected. |
westonruter
added
the
Changelogged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
noindex()function is now deprecated in favor ofwp_robots()as of WP 5.7-alpha.See https://core.trac.wordpress.org/ticket/51511 and https://core.trac.wordpress.org/changeset/49992
Checklist