-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace synchronous URL validation in editor with async validation #5741
Commits on Dec 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 71b36a9 - Browse repository at this point
Copy the full SHA 71b36a9View commit details -
Remove amp_validity REST field and refetch validation errors from RES…
…T endpoint on post save
Configuration menu - View commit details
-
Copy full SHA for a1f70b9 - Browse repository at this point
Copy the full SHA a1f70b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2f96e2 - Browse repository at this point
Copy the full SHA f2f96e2View commit details
Commits on Dec 24, 2020
-
Merge remote-tracking branch 'origin/feature/3821-block-validation-si…
…debar' into feature/2069-async-url-validation
Configuration menu - View commit details
-
Copy full SHA for 3134a15 - Browse repository at this point
Copy the full SHA 3134a15View commit details -
Configuration menu - View commit details
-
Copy full SHA for b814bc6 - Browse repository at this point
Copy the full SHA b814bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81c2c04 - Browse repository at this point
Copy the full SHA 81c2c04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02371e7 - Browse repository at this point
Copy the full SHA 02371e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf97ec6 - Browse repository at this point
Copy the full SHA cf97ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87b7a11 - Browse repository at this point
Copy the full SHA 87b7a11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19e0e82 - Browse repository at this point
Copy the full SHA 19e0e82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02463d9 - Browse repository at this point
Copy the full SHA 02463d9View commit details
Commits on Dec 28, 2020
-
Merge branch 'feature/3821-block-validation-sidebar' into feature/206…
…9-async-url-validation
Configuration menu - View commit details
-
Copy full SHA for 7af91c7 - Browse repository at this point
Copy the full SHA 7af91c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b9b2f - Browse repository at this point
Copy the full SHA e5b9b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 591c424 - Browse repository at this point
Copy the full SHA 591c424View commit details -
Merge remote-tracking branch 'origin/feature/3821-block-validation-si…
…debar' into feature/2069-async-url-validation
Configuration menu - View commit details
-
Copy full SHA for 6fca6e1 - Browse repository at this point
Copy the full SHA 6fca6e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 128ddbe - Browse repository at this point
Copy the full SHA 128ddbeView commit details
Commits on Dec 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3199ade - Browse repository at this point
Copy the full SHA 3199adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b7a2a9 - Browse repository at this point
Copy the full SHA 8b7a2a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a4f6f - Browse repository at this point
Copy the full SHA c6a4f6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3938899 - Browse repository at this point
Copy the full SHA 3938899View commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 513b038 - Browse repository at this point
Copy the full SHA 513b038View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeaa00d - Browse repository at this point
Copy the full SHA eeaa00dView commit details
Commits on Jan 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 65dc9fa - Browse repository at this point
Copy the full SHA 65dc9faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57b6bec - Browse repository at this point
Copy the full SHA 57b6becView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae56751 - Browse repository at this point
Copy the full SHA ae56751View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad58a65 - Browse repository at this point
Copy the full SHA ad58a65View commit details
Commits on Jan 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ea07bad - Browse repository at this point
Copy the full SHA ea07badView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31f8fd2 - Browse repository at this point
Copy the full SHA 31f8fd2View commit details
Commits on Jan 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f283c07 - Browse repository at this point
Copy the full SHA f283c07View commit details
Commits on Jan 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a91b14a - Browse repository at this point
Copy the full SHA a91b14aView commit details
Commits on Jan 22, 2021
-
Pass back post ID from get_url_validation to reduce need for lookups
Also pass back error in REST API response to validate-post-url
Configuration menu - View commit details
-
Copy full SHA for 2343217 - Browse repository at this point
Copy the full SHA 2343217View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86fc614 - Browse repository at this point
Copy the full SHA 86fc614View commit details -
Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…
…069-async-url-validation * 'develop' of github.com:ampproject/amp-wp: (41 commits) Use wp_robots() instead of noindex() in WP 5.7 (#5793) Bump eslint-plugin-jsdoc from 31.0.3 to 31.0.4 Bump google/cloud-storage from 1.23.0 to 1.23.1 Update docs Bump stable tag to 2.0.10 Add tests Restore intrinsic layout to amp-video in amp-story-page-attachment Use nonce scheme instead of auth scheme Utilize hash_equals() in unserialize_validation_error_messages() Fix jsdoc type as ReactElement Persist URL fragment through client-side mobile redirection Bump postcss from 8.2.2 to 8.2.4 Bump eslint-plugin-jsdoc from 30.7.13 to 31.0.3 Prevent infinite mobile redirect when non-AMP page served as AMP Remove the `class` attribute from `amp-fit-text` blocks to unblock block deprecation Update AMP validator spec to 8e02747, restoring intrinsic layout to amp-video Update validator spec to 1130 Update amphtml spec to 2011252111002 Bump @wordpress/compose from 3.23.0 to 3.23.1 Bump @wordpress/block-editor from 5.2.0 to 5.2.1 ...
Configuration menu - View commit details
-
Copy full SHA for c390246 - Browse repository at this point
Copy the full SHA c390246View commit details
Commits on Jan 23, 2021
-
Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…
…069-async-url-validation * 'develop' of github.com:ampproject/amp-wp: (174 commits) Bump @wordpress/compose from 3.23.1 to 3.24.0 Bump @wordpress/api-fetch from 3.21.1 to 3.21.2 Wait for succss notice to appear Ensure "add analytics" button is in view Ensure `$current_screen` global variable does not interfere with tests Bump @wordpress/components from 12.0.1 to 12.0.2 Bump @wordpress/browserslist-config from 2.7.0 to 3.0.0 Bump postcss-loader from 4.1.0 to 4.2.0 Go back to using query_var instead of query_param Update todo for how a condition can be updated Use WP_UnitTestCase for Test_AMP_Options_Manager Add newly-needed use statements for DependencyInjectedTestCase Fix test class namespaces Add assertion for completeness Rename query_var to query_param as a paired URL structure Use hidden prop instead of hidden class Change a todo into a note Use self instead of static Remove PairedUrlExamples copy pasta Fix since phpdoc param ...
Configuration menu - View commit details
-
Copy full SHA for 081fadd - Browse repository at this point
Copy the full SHA 081faddView commit details
Commits on Feb 1, 2021
-
Use custom hook for determining post dirtiness state
The WordPress core `isDirty()` selector gets cleared only if a post gets published or updated. In case of an autosave, it still returns `true`. In order to allow the users to revalidate AMP only if something changed since the last autosave, we had to add a custom hook that tracks the post content changes. Once the first update is detected, a flag `isPostDirty` flag is set in the store and content is no longer checked (it's expensive since each time a content is requested, the `blocks` list must be serialized). When the post gets saved or autosaved, the flag is cleared and the content is observed again.
Configuration menu - View commit details
-
Copy full SHA for 08aaa52 - Browse repository at this point
Copy the full SHA 08aaa52View commit details
Commits on Feb 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 610e515 - Browse repository at this point
Copy the full SHA 610e515View commit details -
Configuration menu - View commit details
-
Copy full SHA for d00066c - Browse repository at this point
Copy the full SHA d00066cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c638a9 - Browse repository at this point
Copy the full SHA 7c638a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7aff222 - Browse repository at this point
Copy the full SHA 7aff222View commit details -
Configuration menu - View commit details
-
Copy full SHA for d59b1eb - Browse repository at this point
Copy the full SHA d59b1ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for da8e35a - Browse repository at this point
Copy the full SHA da8e35aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d287939 - Browse repository at this point
Copy the full SHA d287939View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2710eb7 - Browse repository at this point
Copy the full SHA 2710eb7View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1d91ed8 - Browse repository at this point
Copy the full SHA 1d91ed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31982bf - Browse repository at this point
Copy the full SHA 31982bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ad599 - Browse repository at this point
Copy the full SHA b9ad599View commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for af6d465 - Browse repository at this point
Copy the full SHA af6d465View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7c34512 - Browse repository at this point
Copy the full SHA 7c34512View commit details -
Configuration menu - View commit details
-
Copy full SHA for db5d2cc - Browse repository at this point
Copy the full SHA db5d2ccView commit details
Commits on Feb 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for caf2816 - Browse repository at this point
Copy the full SHA caf2816View commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 6dcb276 - Browse repository at this point
Copy the full SHA 6dcb276View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4025214 - Browse repository at this point
Copy the full SHA 4025214View commit details -
Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…
…069-async-url-validation * 'develop' of github.com:ampproject/amp-wp: (22 commits) Try eliminating selector based on translated string Fix misplacement of AMP error count in editor Fix phpstan static analysis failure Remove redundant assertion Update condition for checking for instance of WP_Post Skip ESLint report generation on PR fork; add ESLint job for PR fork Bump eslint-plugin-jsdoc from 31.6.0 to 31.6.1 Bump @wordpress/browserslist-config from 3.0.0 to 3.0.1 Bump @wordpress/block-editor from 5.2.1 to 5.2.6 Bump @wordpress/blocks from 6.25.2 to 7.0.3 Bump @wordpress/scripts from 13.0.1 to 13.0.3 Bump @wordpress/hooks from 2.11.0 to 2.11.1 Bump @wordpress/data from 4.26.2 to 4.26.6 Add error message for the `invalid-post` error ID Replace `post_supports_amp` with `amp_is_post_supported` Update class-amp-post-type-support.php Update includes/class-amp-post-type-support.php Bump lint-staged from 10.5.3 to 10.5.4 Bump @wordpress/edit-post from 3.26.2 to 3.26.6 Update class-amp-post-type-support.php ...
Configuration menu - View commit details
-
Copy full SHA for 9bffa92 - Browse repository at this point
Copy the full SHA 9bffa92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81ef2ab - Browse repository at this point
Copy the full SHA 81ef2abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bff800 - Browse repository at this point
Copy the full SHA 2bff800View commit details
Commits on Feb 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b29f82d - Browse repository at this point
Copy the full SHA b29f82dView commit details
Commits on Feb 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for f519f7d - Browse repository at this point
Copy the full SHA f519f7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72171c8 - Browse repository at this point
Copy the full SHA 72171c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0843976 - Browse repository at this point
Copy the full SHA 0843976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d134ca - Browse repository at this point
Copy the full SHA 1d134caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f1b2e2 - Browse repository at this point
Copy the full SHA 0f1b2e2View commit details
Commits on Feb 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b6dfc6a - Browse repository at this point
Copy the full SHA b6dfc6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4384e6 - Browse repository at this point
Copy the full SHA f4384e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36bbfcc - Browse repository at this point
Copy the full SHA 36bbfccView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe9e83 - Browse repository at this point
Copy the full SHA cbe9e83View commit details
Commits on Feb 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 739d240 - Browse repository at this point
Copy the full SHA 739d240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fe44f9 - Browse repository at this point
Copy the full SHA 6fe44f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 669fdce - Browse repository at this point
Copy the full SHA 669fdceView commit details -
Configuration menu - View commit details
-
Copy full SHA for bba488b - Browse repository at this point
Copy the full SHA bba488bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63c2272 - Browse repository at this point
Copy the full SHA 63c2272View commit details -
Configuration menu - View commit details
-
Copy full SHA for 914fca6 - Browse repository at this point
Copy the full SHA 914fca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f058ca - Browse repository at this point
Copy the full SHA 5f058caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bc877f - Browse repository at this point
Copy the full SHA 9bc877fView commit details -
Remove needless array nesting in get_url_validation result; fix WP-CL…
…I error handling
Configuration menu - View commit details
-
Copy full SHA for 3080346 - Browse repository at this point
Copy the full SHA 3080346View commit details -
Fix amp validation WP-CLI error handling and ensure AMP URLs get vali…
…dated in non-Standard mode
Configuration menu - View commit details
-
Copy full SHA for b68e2dc - Browse repository at this point
Copy the full SHA b68e2dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a7535d - Browse repository at this point
Copy the full SHA 3a7535dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44bc9db - Browse repository at this point
Copy the full SHA 44bc9dbView commit details
Commits on Feb 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ce3bb7e - Browse repository at this point
Copy the full SHA ce3bb7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f89faa - Browse repository at this point
Copy the full SHA 5f89faaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01faa58 - Browse repository at this point
Copy the full SHA 01faa58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bd0608 - Browse repository at this point
Copy the full SHA 1bd0608View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bce222 - Browse repository at this point
Copy the full SHA 5bce222View commit details -
Configuration menu - View commit details
-
Copy full SHA for 371c626 - Browse repository at this point
Copy the full SHA 371c626View commit details
Commits on Mar 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 79751f5 - Browse repository at this point
Copy the full SHA 79751f5View commit details