Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace synchronous URL validation in editor with async validation #5741

Merged
merged 84 commits into from
Mar 2, 2021

Commits on Dec 23, 2020

  1. Configuration menu
    Copy the full SHA
    71b36a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1f70b9 View commit details
    Browse the repository at this point in the history
  3. Update REST path

    johnwatkins0 committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f2f96e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2020

  1. Merge remote-tracking branch 'origin/feature/3821-block-validation-si…

    …debar' into feature/2069-async-url-validation
    johnwatkins0 committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    3134a15 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b814bc6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81c2c04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    02371e7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf97ec6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    87b7a11 View commit details
    Browse the repository at this point in the history
  7. PHPStan fixes

    johnwatkins0 committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    19e0e82 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    02463d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Configuration menu
    Copy the full SHA
    7af91c7 View commit details
    Browse the repository at this point in the history
  2. Remove constants.js

    johnwatkins0 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    e5b9b2f View commit details
    Browse the repository at this point in the history
  3. Increase test coverage

    johnwatkins0 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    591c424 View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/feature/3821-block-validation-si…

    …debar' into feature/2069-async-url-validation
    johnwatkins0 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    6fca6e1 View commit details
    Browse the repository at this point in the history
  5. Fix errors

    johnwatkins0 committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    128ddbe View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. Configuration menu
    Copy the full SHA
    3199ade View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b7a2a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6a4f6f View commit details
    Browse the repository at this point in the history
  4. Fix failing Jest tests

    johnwatkins0 committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    3938899 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Configuration menu
    Copy the full SHA
    513b038 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eeaa00d View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Configuration menu
    Copy the full SHA
    65dc9fa View commit details
    Browse the repository at this point in the history
  2. Add missing ID property

    delawski committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    57b6bec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae56751 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad58a65 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Configuration menu
    Copy the full SHA
    ea07bad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31f8fd2 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Configuration menu
    Copy the full SHA
    f283c07 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Configuration menu
    Copy the full SHA
    a91b14a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Pass back post ID from get_url_validation to reduce need for lookups

    Also pass back error in REST API response to validate-post-url
    westonruter committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    2343217 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86fc614 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…

    …069-async-url-validation
    
    * 'develop' of github.com:ampproject/amp-wp: (41 commits)
      Use wp_robots() instead of noindex() in WP 5.7 (#5793)
      Bump eslint-plugin-jsdoc from 31.0.3 to 31.0.4
      Bump google/cloud-storage from 1.23.0 to 1.23.1
      Update docs
      Bump stable tag to 2.0.10
      Add tests
      Restore intrinsic layout to amp-video in amp-story-page-attachment
      Use nonce scheme instead of auth scheme
      Utilize hash_equals() in unserialize_validation_error_messages()
      Fix jsdoc type as ReactElement
      Persist URL fragment through client-side mobile redirection
      Bump postcss from 8.2.2 to 8.2.4
      Bump eslint-plugin-jsdoc from 30.7.13 to 31.0.3
      Prevent infinite mobile redirect when non-AMP page served as AMP
      Remove the `class` attribute from `amp-fit-text` blocks to unblock block deprecation
      Update AMP validator spec to 8e02747, restoring intrinsic layout to amp-video
      Update validator spec to 1130
      Update amphtml spec to 2011252111002
      Bump @wordpress/compose from 3.23.0 to 3.23.1
      Bump @wordpress/block-editor from 5.2.0 to 5.2.1
      ...
    westonruter committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    c390246 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2021

  1. Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…

    …069-async-url-validation
    
    * 'develop' of github.com:ampproject/amp-wp: (174 commits)
      Bump @wordpress/compose from 3.23.1 to 3.24.0
      Bump @wordpress/api-fetch from 3.21.1 to 3.21.2
      Wait for succss notice to appear
      Ensure "add analytics" button is in view
      Ensure `$current_screen` global variable does not interfere with tests
      Bump @wordpress/components from 12.0.1 to 12.0.2
      Bump @wordpress/browserslist-config from 2.7.0 to 3.0.0
      Bump postcss-loader from 4.1.0 to 4.2.0
      Go back to using query_var instead of query_param
      Update todo for how a condition can be updated
      Use WP_UnitTestCase for Test_AMP_Options_Manager
      Add newly-needed use statements for DependencyInjectedTestCase
      Fix test class namespaces
      Add assertion for completeness
      Rename query_var to query_param as a paired URL structure
      Use hidden prop instead of hidden class
      Change a todo into a note
      Use self instead of static
      Remove PairedUrlExamples copy pasta
      Fix since phpdoc param
      ...
    westonruter committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    081fadd View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2021

  1. Use custom hook for determining post dirtiness state

    The WordPress core `isDirty()` selector gets cleared only if a post gets published or updated. In case of an autosave, it still returns `true`.
    
    In order to allow the users to revalidate AMP only if something changed since the last autosave, we had to add a custom hook that tracks the post content changes.
    
    Once the first update is detected, a flag `isPostDirty` flag is set in the store and content is no longer checked (it's expensive since each time a content is requested, the `blocks` list must be serialized).
    
    When the post gets saved or autosaved, the flag is cleared and the content is observed again.
    delawski committed Feb 1, 2021
    Configuration menu
    Copy the full SHA
    08aaa52 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Configuration menu
    Copy the full SHA
    610e515 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d00066c View commit details
    Browse the repository at this point in the history
  3. Fix JS lint issues

    delawski committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    7c638a9 View commit details
    Browse the repository at this point in the history
  4. Update package-lock.json

    delawski committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    7aff222 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d59b1eb View commit details
    Browse the repository at this point in the history
  6. Minor comments updates

    delawski committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    da8e35a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d287939 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2710eb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Change custom hook name

    delawski committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    1d91ed8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    31982bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9ad599 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Configuration menu
    Copy the full SHA
    af6d465 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Configuration menu
    Copy the full SHA
    7c34512 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    db5d2cc View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. Configuration menu
    Copy the full SHA
    caf2816 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Configuration menu
    Copy the full SHA
    6dcb276 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4025214 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'develop' of github.com:ampproject/amp-wp into feature/2…

    …069-async-url-validation
    
    * 'develop' of github.com:ampproject/amp-wp: (22 commits)
      Try eliminating selector based on translated string
      Fix misplacement of AMP error count in editor
      Fix phpstan static analysis failure
      Remove redundant assertion
      Update condition for checking for instance of WP_Post
      Skip ESLint report generation on PR fork; add ESLint job for PR fork
      Bump eslint-plugin-jsdoc from 31.6.0 to 31.6.1
      Bump @wordpress/browserslist-config from 3.0.0 to 3.0.1
      Bump @wordpress/block-editor from 5.2.1 to 5.2.6
      Bump @wordpress/blocks from 6.25.2 to 7.0.3
      Bump @wordpress/scripts from 13.0.1 to 13.0.3
      Bump @wordpress/hooks from 2.11.0 to 2.11.1
      Bump @wordpress/data from 4.26.2 to 4.26.6
      Add error message for the `invalid-post` error ID
      Replace `post_supports_amp` with `amp_is_post_supported`
      Update class-amp-post-type-support.php
      Update includes/class-amp-post-type-support.php
      Bump lint-staged from 10.5.3 to 10.5.4
      Bump @wordpress/edit-post from 3.26.2 to 3.26.6
      Update class-amp-post-type-support.php
      ...
    westonruter committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    9bffa92 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    81ef2ab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2bff800 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    b29f82d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Configuration menu
    Copy the full SHA
    f519f7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72171c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0843976 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1d134ca View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f1b2e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    b6dfc6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4384e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    36bbfcc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cbe9e83 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    739d240 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fe44f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    669fdce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bba488b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    63c2272 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    914fca6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5f058ca View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9bc877f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3080346 View commit details
    Browse the repository at this point in the history
  10. Fix amp validation WP-CLI error handling and ensure AMP URLs get vali…

    …dated in non-Standard mode
    westonruter committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b68e2dc View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3a7535d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    44bc9db View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Configuration menu
    Copy the full SHA
    ce3bb7e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f89faa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01faa58 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1bd0608 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5bce222 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    371c626 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    79751f5 View commit details
    Browse the repository at this point in the history