Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gfycat #7610

Closed
westonruter opened this issue Sep 2, 2023 · 1 comment · Fixed by #7612
Closed

Remove Gfycat #7610

westonruter opened this issue Sep 2, 2023 · 1 comment · Fixed by #7612
Assignees
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@westonruter
Copy link
Member

Bug Description

The Gfycat service has been shut down: https://techcrunch.com/2023/07/05/gfycat-shuts-down-on-september-1/amp/

This is causing unit tests to fail. We need to remove support for Gfycat.

Expected Behaviour

Any sanitizers and embed handlers for Gfycat should be removed since the service is shut down.

Screenshots

No response

PHP Version

No response

Plugin Version

n/a

AMP plugin template mode

Standard, Transitional, Reader

WordPress Version

No response

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Bug Something isn't working label Sep 2, 2023
@westonruter westonruter added this to the v2.4.3 milestone Sep 2, 2023
@pavanpatil1
Copy link

QA Passed ✅

The Embedding of Gyfcat URLs is not working. After embedding a Gyfcat URL the link is visible.

Details

image

When a URL is embedded using an iframe, the content is displayed within the tag instead of amp-gyfcat.

Details

image

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
@github-project-automation github-project-automation bot moved this to QA Passed in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants