Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP Settings Page > Site Scan screen there should be space between buttons #7001

Closed
pooja-muchandikar opened this issue Mar 28, 2022 · 4 comments · Fixed by #7010
Closed
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@pooja-muchandikar
Copy link

Bug Description

Site scan screen can we have some padding between the Rescan Site and Browse Site buttons?

The buttons looks attached on click.

Expected Behaviour

There should be some padding between the buttons

Screenshots

image

PHP Version

No response

Plugin Version

2.2.2alpha

AMP plugin template mode

Standard

WordPress Version

5.9.2

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@pooja-muchandikar pooja-muchandikar added the Bug Something isn't working label Mar 28, 2022
@maitreyie-chavan maitreyie-chavan added this to the v2.2.2 milestone Mar 28, 2022
@westonruter
Copy link
Member

I see this is also the case for the Review section:

image

@westonruter
Copy link
Member

In the Onboarding Wizard there is a 1rem space:

image

@westonruter
Copy link
Member

I believe it will be as simple as this:

diff --git a/assets/src/settings-page/style.css b/assets/src/settings-page/style.css
index e22f669a8..0e65d6fad 100644
--- a/assets/src/settings-page/style.css
+++ b/assets/src/settings-page/style.css
@@ -578,6 +578,10 @@ li.error-kept {
 	padding-right: 2.25rem;
 }
 
+.amp .settings-site-scan__footer .components-button + .components-button {
+	margin-left: 1rem;
+}
+
 /* Review. */
 #site-review {
 	margin-bottom: 2.5rem;
@@ -637,6 +641,10 @@ li.error-kept {
 	padding-right: 2.25rem;
 }
 
+.amp .settings-site-review__actions .components-button + .components-button {
+	margin-left: 1rem;
+}
+
 /* Other Settings */
 .amp-other-settings section + section {
 	margin-top: 2rem;

@pooja-muchandikar
Copy link
Author

QA Passed ✅

Spacing between buttons is fixed for Site Scan and Review section.

Before:

Site Scan Section
Screenshot 2022-03-30 at 11 48 06 AM


Review Section
Screenshot 2022-03-30 at 11 49 24 AM


After fix:

Site Scan Section
Screenshot 2022-03-30 at 11 38 57 AM


Review Section
Screenshot 2022-03-30 at 11 42 27 AM


@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants