Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do async site scanning after theme activation #6814

Closed
westonruter opened this issue Dec 23, 2021 · 2 comments · Fixed by #6859
Closed

Do async site scanning after theme activation #6814

westonruter opened this issue Dec 23, 2021 · 2 comments · Fixed by #6859
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P1 Medium priority Site Scanning
Milestone

Comments

@westonruter
Copy link
Member

Feature Description

With #6685 we now do async site scanning after plugin activation. The same should be done when activating a new theme. Granted, it is much less common to be switching themes vs activating plugins, so this is not as high of a priority. Also the weekly cron will show theme results when it runs eventually. But still it would be good to show scan results sooner rather than later.

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added Enhancement New feature or improvement of an existing one Site Scanning labels Dec 23, 2021
@westonruter westonruter added this to the v2.3 milestone Dec 23, 2021
@westonruter westonruter added the P1 Medium priority label Dec 23, 2021
@delawski delawski self-assigned this Feb 2, 2022
@maitreyie-chavan maitreyie-chavan modified the milestones: v2.3, v2.2.2 Feb 8, 2022
@pooja-muchandikar
Copy link

QA Passed ✅ for the main feature implemented.

Scan results with no errors after theme activation

Scan-results with no errors


Scan results with errors after theme activation

Scan results with errors


Screenshot 2022-03-21 at 7 09 44 PM


But following are some observations:

  • 1. As per comment Message for technical and non-technical user are different. But currently same message is shown to both type of users.
technical-non-technnical-message.mov

@westonruter
Copy link
Member Author

  • Message for technical and non-technical user are different. But currently same message is shown to both type of users.

The difference is non-technical users wouldn't be shown the list of URLs? I see no reason why that would be preferable. So I think the way it is now is best.

Moving to QA Passed.

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one P1 Medium priority Site Scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants